Infinidat Cinder driver generic volume migration feature is broken

[Alexander Deiter]

The Infinidat storage requires unique volume names for all pools within the same cluster.
But the Infinidat Cinder driver does not implement the standard function - update_migrated_volume.
These two circumstances make it impossible to perform a generic volume migration between two storage pools within the same cluster.

Steps to reproduce:
* Install an OpenStack environment
* Configure two Infinidat iSCSI or FC backends: backend1 and backend2
* Create a volume in the backend1
* Try to migrate the volume from backend1 to backend2

Expected results:
Success

Actual results:
The migration process fails with error:
ERROR: The volume cannot be deleted. Volume 'openstack-vol-1df0ce75-0356-4584-910b-7ab0f70e0175' has active mappings

Note:
The same issue can be reproduced in devstack environment with enabled multi-backend configuration and the Tempest test suite:
{0} tempest.scenario.test_volume_migrate_attached.TestVolumeMigrateRetypeAttached.test_volume_migrate_attached [97.003798s] ... FAILED
...
ERROR: The volume cannot be deleted. Volume 'openstack-vol-1df0ce75-0356-4584-910b-7ab0f70e0175' has active mappings

Root cause:
Function update_migrated_volume is not implemented in the Infinidat Cinder driver.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/850320

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/850320
Committed: https://opendev.org/openstack/cinder/commit/9a29d57a61cfb845eabc2cc7f72480b48b9a68e9
Submitter: "Zuul (22348)"
Branch: master

commit 9a29d57a61cfb845eabc2cc7f72480b48b9a68e9
Author: Alexander Deiter <email address hidden>
Date: Wed Jul 6 17:12:47 2022 +0400

    Fix Infinidat driver generic volume migration

    - Use volume name_id to resolve Infinidat volume name.
    - Add update_migrated_volume function to fix generic volume
      migration between two pools within the same storage cluster.

    Closes-bug: #1982405
    Change-Id: I80923f9968de31738c554b77c0942a6182f0e67c
    Signed-off-by: Alexander Deiter <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/cinder/+/868179

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 22.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/868179
Committed: https://opendev.org/openstack/cinder/commit/40ee7d0739fd65258207709511842b5eddbac4b7
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 40ee7d0739fd65258207709511842b5eddbac4b7
Author: Alexander Deiter <email address hidden>
Date: Wed Jul 6 17:12:47 2022 +0400

    Fix Infinidat driver generic volume migration

    - Use volume name_id to resolve Infinidat volume name.
    - Add update_migrated_volume function to fix generic volume
      migration between two pools within the same storage cluster.

    Closes-bug: #1982405
    Change-Id: I80923f9968de31738c554b77c0942a6182f0e67c
    Signed-off-by: Alexander Deiter <email address hidden>
    (cherry picked from commit 9a29d57a61cfb845eabc2cc7f72480b48b9a68e9)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 21.3.1 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/cinder/+/906140

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/cinder/+/906281

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/cinder/+/906282

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/cinder/+/905771

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Brian Rosmaita <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/cinder/+/889240
Reason: The stable/yoga branch is now in Unmaintained status, and is in the process of being tagged end-of-maintenance and deleted by change I99a8120217aa. If you want to continue with this patch, please propose it to the unmaintained/yoga branch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Brian Rosmaita <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/cinder/+/905771
Reason: Cinder is EOL'ing the Ussuri series: see https://review.opendev.org/c/openstack/releases/+/884942

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/cinder/+/906282
Reason: stable/victoria branch of openstack/cinder is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/cinder/+/906281
Reason: stable/wallaby branch of openstack/cinder is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/wallaby if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/xena
Review: https://review.opendev.org/c/openstack/cinder/+/906140
Reason: stable/xena branch of openstack/cinder is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/xena if you want to further work on this patch.