[storwize] Driver Initialization error w.r.t default portset

[Mounika Sreeram]

Driver initialization failed with the below error:
ERROR cinder.volume.manager cinder.exception.InvalidInput: Invalid input received: The storage device does not support iSCSI. Please configure the device to support iSCSI or switch to a driver using a different protocol.

Steps to reproduce:
1. Added storwize_portset=<portset> in cinder.conf
2. Restart the cinder services

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/850310

[Harsh Ailani (haailani)]

Bug Analysis:
During initialization add_iscsi_ip_addrs() is by default taking the portset value as portset0
But if the portset0 is not defined or is not supposed to be used, it will throw error in driver initialization

Need to fix the code to fetch the storwize_portset value from cinder.conf during intialization. If it is not defined, only then take portset0 during initialization.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/850310
Committed: https://opendev.org/openstack/cinder/commit/374efd15798beefbf95754d7950e782a53f88553
Submitter: "Zuul (22348)"
Branch: master

commit 374efd15798beefbf95754d7950e782a53f88553
Author: haailani <email address hidden>
Date: Tue Jul 19 09:51:13 2022 +0000

    [SVf]: Incorrect portset value during driver intialization

    [Spectrum Virtualize family] During initialization
    by default taking the portset value is set to portset0,
    even when a different portset is defined in the cinder.conf

    During initialization, if the portset is not defined in cinder.conf,
    only then it should pick portset0. Otherwise it should pick the value
    from cinder.conf

    Closes-Bug: #1982078
    Change-Id: I1519b23a44ca8e86c2a969353f275a711d51454f

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 21.0.0.0rc1 release candidate.