devstack-plugin-nfs-tempest-full CI job failing

[Eric Harney]

Since this tempest change landed:

https://review.opendev.org/c/openstack/tempest/+/842432

devstack-plugin-nfs-tempest-full is failing with:

tempest.api.volume.admin.test_backends_capabilities.BackendsCapabilitiesAdminTestsJSON.test_compare_volume_stats_values[id-a9035743-d46a-47c5-9cb7-3c80ea16dea0]
----------------------------------------------------------------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/opt/stack/tempest/tempest/api/volume/admin/test_backends_capabilities.py", line 91, in test_compare_volume_stats_values
    self.assertEqual(expected_list, observed_list)

      File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 393, in assertEqual
    self.assertThat(observed, matcher, message)

      File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 480, in assertThat
    raise mismatch_error

    testtools.matchers._impl.MismatchError: [('Open Source', 'nfs', 'nfs')] != [('Open Source', 'nfs', 'NFS')]

job history: https://zuul.opendev.org/t/openstack/builds?job_name=devstack-plugin-nfs-tempest-full&project=openstack/cinder

[Gorka Eguileor (gorka)]

Proposed fix https://review.opendev.org/c/openstack/cinder/+/847953

[Gorka Eguileor (gorka)]

This test fails both for Cinder master and for stable releases, but for different reasons.
In master it fails because in some cases Cinder flaps the value, for example from NFS to nfs.
In stable branches it fails because tempest test after https://review.opendev.org/c/openstack/tempest/+/842432 is no longer backward compatible with Cinder releases prior to https://review.opendev.org/c/openstack/cinder/+/836069 (depends on the driver).

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tempest/+/847952
Committed: https://opendev.org/openstack/tempest/commit/d30577d07ceb184f7cf82b2d2f000a6381fb024d
Submitter: "Zuul (22348)"
Branch: master

commit d30577d07ceb184f7cf82b2d2f000a6381fb024d
Author: Gorka Eguileor <email address hidden>
Date: Tue Jun 28 12:58:43 2022 +0200

    Fix backward compatibility of compare volume stats

    When we fixed tempest test "test_compare_volume_stats_values" (Change-Id
    I04d0eaa1f6dba16bd11052f91a3d1d0967029ea6) to make it work with the
    "storage_protocol" canonical names that are returned by Cinder master on
    the get-pools call (after Change-Id Change-Id:
    I07d74078dbb102490dd722029e32c74cec3aa44c) we made the test non-backward
    compatible, because stable releases don't return canonical names.

    For example the NFS driver will return value "nfs" in stable releases,
    but the test expects it to be "NFS" and thus will fail.

    This patch fixes this by converting "storage_protocol" for the result of
    both the get-pools and get-capabilities calls.

    So we have 3 different cases:

    - Current cinder master code --> Should work with current test

    - Stable cinder branches with some backends (eg: NFS) --> Fixed by this
      patch

    - Future Cinder when get-capabilities returns canonical name (Change-Id
      I8b21fbc2c8ef29689f101f6c397550604662cd8a) --> Works with or without
      this patch.

    Closes-Bug: #1979826
    Change-Id: I56099463791bb9a0bda18cbf7d315825562042aa

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tempest 32.0.0 release.