[DEFAULT] use_forwarded_for is duplicate of the HTTPProxyToWSGI middleware

[Takashi Kajinami]

The [DEFAULT] use_forwarded_for parameter enables detection of remote address by the X-Forwarded-For request header.
However this functionality is duplicate of the HTTPProxyToWSGI middleware in the oslo.middleware library.

Now the HTTPProxyToWSGI middleware is enabled in api pipeline by default, and also is globally used by multiple components, the own use_forwarded_for parameter can be removed.

[Goutham Pacha Ravi (gouthamr)]

Change proposed to branch: master (manila)
    https://review.opendev.org/c/openstack/manila/+/836251

[Vida Haririan (vhariria)]

Fix was proposed #link https://review.opendev.org/c/openstack/manila/+/836251 (Deprecate [DEFAULT] use_forwarded_for)

[Vida Haririan (vhariria)]

See additional discussions at https://meetings.opendev.org/meetings/manila/2022/manila.2022-04-21-15.00.log.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/836251
Committed: https://opendev.org/openstack/manila/commit/b24fc87a1d26ce3447c5fc914f55fb199a2b7702
Submitter: "Zuul (22348)"
Branch: master

commit b24fc87a1d26ce3447c5fc914f55fb199a2b7702
Author: Takashi Kajinami <email address hidden>
Date: Mon Apr 4 00:27:42 2022 +0900

    Deprecate [DEFAULT] use_forwarded_for

    ... because functionality of this parameter is effectively duplicate of
    the HTTPProxyToWSGI middleware in oslo.middleware library.

    Closes-Bug: #1967686
    Change-Id: I4db615093b739c7ff582f348a6fb6eabb8068257

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/836253
Committed: https://opendev.org/openstack/nova/commit/cf906cdcc25c112956f56f9fb9f62b2cfdeacc65
Submitter: "Zuul (22348)"
Branch: master

commit cf906cdcc25c112956f56f9fb9f62b2cfdeacc65
Author: Takashi Kajinami <email address hidden>
Date: Mon Apr 4 00:43:18 2022 +0900

    Deprecate [api] use_forwarded_for

    ... because functionality of this parameter is effectively duplicate of
    the HTTPProxyToWSGI middleware in oslo.middleware library.

    Closes-Bug: #1967686
    Change-Id: Ifebcfb6b5c1594c075bb9c152a06aa7af7c61bc8

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 26.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 15.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/903339

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/903340

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Takashi Kajinami <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/903340
Reason: this is duplicate of https://review.opendev.org/c/openstack/cinder/+/836252

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/903339
Committed: https://opendev.org/openstack/nova/commit/a5f68d355c97baddf2baf46d9630175d65c36968
Submitter: "Zuul (22348)"
Branch: master

commit a5f68d355c97baddf2baf46d9630175d65c36968
Author: Takashi Kajinami <email address hidden>
Date: Mon Dec 11 21:50:41 2023 +0900

    Remove deprecated [api] use_forwarded_for

    This option was deprecated in favor of the HTTPProxyToWSGI middleware
    in 26.0.0 release[1].

    [1] cf906cdcc25c112956f56f9fb9f62b2cfdeacc65

    Related-Bug: #1967686
    Change-Id: Iad8880127531dc2788d646f8a05b5c17fd9d0969