NetApp ONTAP driver shows type error exception when replicating FlexGroups

[Luisa]

Description
===========
The get_volume_state function accepts two arguments: name and junction_path. However, its been called with a wrong parameter name, flexvol_name, at _wait_volume_is_online() in data_motion.py
This raises a type error exception on NetApp driver.

Steps to reproduce
==================
[Requires a flexgroup replication environment on OTAP]
* Setup a flexgroup on SVM A
* Setup SVM B as a replica for SVM A
* Create a peer for snapmirror applications between SVM A and SVM B
* Run or restart cinder

Expected result
===============
Replica on SVM B sucessfully created without any errors on cinder-volume log.

Actual result
=============
The replica on SVM is created, but get_volume_state() fails with the following message on cinder-volume log: "got an unexpected keyword argument 'flexvol_name'"

Proposed solution
==================
On cinder/volume/drivers/netapp/dataontap/utils/data_motion.py fix the parameter name, changing it from "flexvol_name" to just "name".

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/826350

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/826350
Committed: https://opendev.org/openstack/cinder/commit/a4ea2db290f5671d8f64cec3972080ab37a32794
Submitter: "Zuul (22348)"
Branch: master

commit a4ea2db290f5671d8f64cec3972080ab37a32794
Author: Luisa Amaral <email address hidden>
Date: Tue Jan 25 17:50:58 2022 +0000

    NetApp ONTAP: Fix type error exception in get_volume_state

    When a Flexgroup is being replicated in ONTAP, a snapmirror is created.
    However, while ensuring the snapmirror creation, a type error occurs.

    The function get_volume_state has a parameter name set as 'name', and it
    is called under 'flexvol_name' causing the type error exception.

    This patch solves the bug by fixing 'flexvol_name' to 'name'

    Closes-Bug: #1958245
    Change-Id: Ibf9823a47980901042a9c95ca3cd850cd14f0033

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 21.0.0.0rc1 release candidate.