[oslo.utils] Usage of human output is deprecated in QemuImgInfo

Bug #1940540 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Takashi Kajinami

Bug Description

Support for the human format by oslo_utils.imageutils.QemuImgInfo was deprecated since oslo.utils 4.9.1 [1] and usage of human format triggers the following deprecation warning.

The human format is deprecated and the format parameter will be removed. Use explicitly json instead

[1] https://review.opendev.org/c/openstack/oslo.utils/+/710005

Changed in cinder:
status: New → In Progress
Revision history for this message
Takashi Kajinami (kajinamit) wrote :

I have submitted a fix[1] but it seems the change causes failure in the cinder-tempest-plugin-lvm-lio-barbican job.
 [1] https://review.opendev.org/c/openstack/cinder/+/799663

Looking at job output I see the following test case is failing because of timeout during ssh'ing an instance but I could not find any clear error with it.

cinder_tempest_plugin.scenario.test_volume_encrypted.TestEncryptedCinderVolumes.test_boot_cloned_encrypted_volume
 https://zuul.opendev.org/t/openstack/build/3ba8de5f60c24243868526e42c30388e

Honestly I have no idea how I can look into the failure and I appreciate any help here to make all jobs pass...

Changed in cinder:
importance: Undecided → High
tags: added: oslo qemu-img
tags: added: imaeutils
summary: - Usage of human output is deprecated in QemuImgInfo
+ [oslo.utils] Usage of human output is deprecated in QemuImgInfo
Changed in cinder:
assignee: nobody → Takashi Kajinami (kajinamit)
Changed in cinder:
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/799663
Committed: https://opendev.org/openstack/cinder/commit/c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9
Submitter: "Zuul (22348)"
Branch: master

commit c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9
Author: Takashi Kajinami <email address hidden>
Date: Tue Jul 6 21:48:44 2021 +0900

    Use the json format output of qemu-img info

    Support for the human format by oslo_utils.imageutils.QemuImgInfo was
    deprecated since oslo.utils 4.9.1 [1]. This change replaces the human
    format with the json format which will be used by default.

    [1] 73eb0673f627aad382e08a816191b637af436465

    Closes-Bug: #1940540
    Change-Id: Ia0353204abf849467106ee08982d1271de23101a

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/cinder/+/869981

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/cinder/+/869985

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/cinder/+/869987

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/cinder/+/870013

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/cinder/+/870020

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/cinder/+/870029

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/cinder/+/870090

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/869981
Committed: https://opendev.org/openstack/cinder/commit/11b0f97a013189fe985deec4f776a7719a6ad089
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 11b0f97a013189fe985deec4f776a7719a6ad089
Author: Takashi Kajinami <email address hidden>
Date: Tue Jul 6 21:48:44 2021 +0900

    Use the json format output of qemu-img info

    Support for the human format by oslo_utils.imageutils.QemuImgInfo was
    deprecated since oslo.utils 4.9.1 [1]. This change replaces the human
    format with the json format which will be used by default.

    [1] 73eb0673f627aad382e08a816191b637af436465

    Backport note: The json format is preferable because it allows access
    to format specific details (since oslo.utils 4.1.0). These details
    are not present when the default 'human' format is used. See change
    I133da07a5a9628b8a9 for details.

    Closes-Bug: #1940540
    Change-Id: Ia0353204abf849467106ee08982d1271de23101a
    (cherry picked from commit c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/870013
Committed: https://opendev.org/openstack/cinder/commit/60a5de1f6df78b04d5b9e8438b506d6651eaefd8
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 60a5de1f6df78b04d5b9e8438b506d6651eaefd8
Author: Takashi Kajinami <email address hidden>
Date: Tue Jul 6 21:48:44 2021 +0900

    Use the json format output of qemu-img info

    Support for the human format by oslo_utils.imageutils.QemuImgInfo was
    deprecated since oslo.utils 4.9.1 [1]. This change replaces the human
    format with the json format which will be used by default.

    [1] 73eb0673f627aad382e08a816191b637af436465

    Backport note: The json format is preferable because it allows access
    to format specific details (since oslo.utils 4.1.0). These details
    are not present when the default 'human' format is used. See change
    I133da07a5a9628b8a9 for details.

    Closes-Bug: #1940540
    Change-Id: Ia0353204abf849467106ee08982d1271de23101a
    (cherry picked from commit c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9)
    (cherry picked from commit 11b0f97a013189fe985deec4f776a7719a6ad089)
    (cherry picked from commit 4cef5c0c4244fff8ec02809cbf295267b3f6bde9)
    (cherry picked from commit 9810c05e743297171c6cf7572658cbd6a19c5a47)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/870029
Committed: https://opendev.org/openstack/cinder/commit/6df27994d9b0ca0801a45b26c2bdf60c8eb6a268
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 6df27994d9b0ca0801a45b26c2bdf60c8eb6a268
Author: Takashi Kajinami <email address hidden>
Date: Tue Jul 6 21:48:44 2021 +0900

    Use the json format output of qemu-img info

    Support for the human format by oslo_utils.imageutils.QemuImgInfo was
    deprecated since oslo.utils 4.9.1 [1]. This change replaces the human
    format with the json format which will be used by default.

    [1] 73eb0673f627aad382e08a816191b637af436465

    Backport note: The json format is preferable because it allows access
    to format specific details (since oslo.utils 4.1.0). These details
    are not present when the default 'human' format is used. See change
    I133da07a5a9628b8a9 for details.

    Closes-Bug: #1940540
    Change-Id: Ia0353204abf849467106ee08982d1271de23101a
    (cherry picked from commit c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9)
    (cherry picked from commit 11b0f97a013189fe985deec4f776a7719a6ad089)
    (cherry picked from commit 4cef5c0c4244fff8ec02809cbf295267b3f6bde9)
    (cherry picked from commit 9810c05e743297171c6cf7572658cbd6a19c5a47)
    (cherry picked from commit 60a5de1f6df78b04d5b9e8438b506d6651eaefd8)
    (cherry picked from commit 6a1260ea80332d28bbe73a85e6fa94e28fd31cd2)
    Conflicts:
      cinder/tests/unit/volume/drivers/test_nfs.py
      - patch changed QEMU_IMG_INFO_OUT5 test data which isn't present
        in ussuri
      cinder/volume/flows/manager/create_volume.py
      - parent patch of 6a1260ea8 imported netutils, but that's not used
        in this file in ussuri

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/869985
Committed: https://opendev.org/openstack/cinder/commit/4cef5c0c4244fff8ec02809cbf295267b3f6bde9
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 4cef5c0c4244fff8ec02809cbf295267b3f6bde9
Author: Takashi Kajinami <email address hidden>
Date: Tue Jul 6 21:48:44 2021 +0900

    Use the json format output of qemu-img info

    Support for the human format by oslo_utils.imageutils.QemuImgInfo was
    deprecated since oslo.utils 4.9.1 [1]. This change replaces the human
    format with the json format which will be used by default.

    [1] 73eb0673f627aad382e08a816191b637af436465

    Backport note: The json format is preferable because it allows access
    to format specific details (since oslo.utils 4.1.0). These details
    are not present when the default 'human' format is used. See change
    I133da07a5a9628b8a9 for details.

    Closes-Bug: #1940540
    Change-Id: Ia0353204abf849467106ee08982d1271de23101a
    (cherry picked from commit c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9)
    (cherry picked from commit 11b0f97a013189fe985deec4f776a7719a6ad089)

tags: added: in-stable-yoga
tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/869987
Committed: https://opendev.org/openstack/cinder/commit/9810c05e743297171c6cf7572658cbd6a19c5a47
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 9810c05e743297171c6cf7572658cbd6a19c5a47
Author: Takashi Kajinami <email address hidden>
Date: Tue Jul 6 21:48:44 2021 +0900

    Use the json format output of qemu-img info

    Support for the human format by oslo_utils.imageutils.QemuImgInfo was
    deprecated since oslo.utils 4.9.1 [1]. This change replaces the human
    format with the json format which will be used by default.

    [1] 73eb0673f627aad382e08a816191b637af436465

    Backport note: The json format is preferable because it allows access
    to format specific details (since oslo.utils 4.1.0). These details
    are not present when the default 'human' format is used. See change
    I133da07a5a9628b8a9 for details.

    Closes-Bug: #1940540
    Change-Id: Ia0353204abf849467106ee08982d1271de23101a
    (cherry picked from commit c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9)
    (cherry picked from commit 11b0f97a013189fe985deec4f776a7719a6ad089)
    (cherry picked from commit 4cef5c0c4244fff8ec02809cbf295267b3f6bde9)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/train)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/870090
Committed: https://opendev.org/openstack/cinder/commit/9f9194d804c4685d21f9fe0f767d20faee1a8a88
Submitter: "Zuul (22348)"
Branch: stable/train

commit 9f9194d804c4685d21f9fe0f767d20faee1a8a88
Author: Takashi Kajinami <email address hidden>
Date: Tue Jul 6 21:48:44 2021 +0900

    Use the json format output of qemu-img info

    Support for the human format by oslo_utils.imageutils.QemuImgInfo was
    deprecated since oslo.utils 4.9.1 [1]. This change replaces the human
    format with the json format which will be used by default.

    [1] 73eb0673f627aad382e08a816191b637af436465

    Backport note: The json format is preferable because it allows access
    to format specific details (since oslo.utils 4.1.0). These details
    are not present when the default 'human' format is used. See change
    I133da07a5a9628b8a9 for details.

    Closes-Bug: #1940540
    Change-Id: Ia0353204abf849467106ee08982d1271de23101a
    (cherry picked from commit c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9)
    (cherry picked from commit 11b0f97a013189fe985deec4f776a7719a6ad089)
    (cherry picked from commit 4cef5c0c4244fff8ec02809cbf295267b3f6bde9)
    (cherry picked from commit 9810c05e743297171c6cf7572658cbd6a19c5a47)
    (cherry picked from commit 60a5de1f6df78b04d5b9e8438b506d6651eaefd8)
    (cherry picked from commit 6a1260ea80332d28bbe73a85e6fa94e28fd31cd2)
    Conflicts:
      cinder/tests/unit/volume/drivers/test_nfs.py
      - patch changed QEMU_IMG_INFO_OUT5 test data which isn't present
        in ussuri
      cinder/volume/flows/manager/create_volume.py
      - parent patch of 6a1260ea8 imported netutils, but that's not used
        in this file in ussuri
    (cherry picked from commit 6df27994d9b0ca0801a45b26c2bdf60c8eb6a268)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/870020
Committed: https://opendev.org/openstack/cinder/commit/6a1260ea80332d28bbe73a85e6fa94e28fd31cd2
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 6a1260ea80332d28bbe73a85e6fa94e28fd31cd2
Author: Takashi Kajinami <email address hidden>
Date: Tue Jul 6 21:48:44 2021 +0900

    Use the json format output of qemu-img info

    Support for the human format by oslo_utils.imageutils.QemuImgInfo was
    deprecated since oslo.utils 4.9.1 [1]. This change replaces the human
    format with the json format which will be used by default.

    [1] 73eb0673f627aad382e08a816191b637af436465

    Backport note: The json format is preferable because it allows access
    to format specific details (since oslo.utils 4.1.0). These details
    are not present when the default 'human' format is used. See change
    I133da07a5a9628b8a9 for details.

    Closes-Bug: #1940540
    Change-Id: Ia0353204abf849467106ee08982d1271de23101a
    (cherry picked from commit c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9)
    (cherry picked from commit 11b0f97a013189fe985deec4f776a7719a6ad089)
    (cherry picked from commit 4cef5c0c4244fff8ec02809cbf295267b3f6bde9)
    (cherry picked from commit 9810c05e743297171c6cf7572658cbd6a19c5a47)
    (cherry picked from commit 60a5de1f6df78b04d5b9e8438b506d6651eaefd8)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 19.2.0

This issue was fixed in the openstack/cinder 19.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 20.1.0

This issue was fixed in the openstack/cinder 20.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 21.1.0

This issue was fixed in the openstack/cinder 21.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 22.0.0.0rc1

This issue was fixed in the openstack/cinder 22.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cinder (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/900422

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder train-eol

This issue was fixed in the openstack/cinder train-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder ussuri-eol

This issue was fixed in the openstack/cinder ussuri-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder victoria-eom

This issue was fixed in the openstack/cinder victoria-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder wallaby-eom

This issue was fixed in the openstack/cinder wallaby-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.