PowerMax - legacy PowerMax issue with generations

[Helen Walsh]

In the previous version of PowerMax OS and HyperMax OS, generations of snapVx were
used instead of unique snap ids which were just introduced.
A generation can be returned as a 0 integer which equates to False
in python. The fix is to convert the int to a string if it is
returned from REST as an int.

How to reproduce.
Older versions of PowerMax and HyperMax OS installed, Unisphere for PowerMax can return a 0 integer which causes a failure in snapshots

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/778907
Committed: https://opendev.org/openstack/cinder/commit/ee1b5e2b756f49a384d348555e9611526c0c1217
Submitter: "Zuul (22348)"
Branch: master

commit ee1b5e2b756f49a384d348555e9611526c0c1217
Author: Helen Walsh <email address hidden>
Date: Fri Mar 5 12:56:28 2021 +0000

    PowerMax Driver - Fix for legacy PowerMax OS around generations

    In the previous version of PowerMax OS generations of snapVx were
    used instead of unique snap ids which were just introduced.
    A generation can be returned as a 0 integer which equates to False
    in python. The fix is to convert the int to a string if it is
    returned from REST as an int.

    Closes-Bug: #1938572
    Change-Id: I5b660776190f3026296d6d3237bd3b0d609f769f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/cinder/+/816695

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/816695
Committed: https://opendev.org/openstack/cinder/commit/fe1e6be52f84d1aafdb4a140dfdaf4d0277b9623
Submitter: "Zuul (22348)"
Branch: stable/xena

commit fe1e6be52f84d1aafdb4a140dfdaf4d0277b9623
Author: Helen Walsh <email address hidden>
Date: Fri Mar 5 12:56:28 2021 +0000

    PowerMax Driver - Fix for legacy PowerMax OS around generations

    In the previous version of PowerMax OS generations of snapVx were
    used instead of unique snap ids which were just introduced.
    A generation can be returned as a 0 integer which equates to False
    in python. The fix is to convert the int to a string if it is
    returned from REST as an int.

    Closes-Bug: #1938572
    Change-Id: I5b660776190f3026296d6d3237bd3b0d609f769f
    (cherry picked from commit ee1b5e2b756f49a384d348555e9611526c0c1217)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 19.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 20.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/cinder/+/898069

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/cinder/+/898069
Reason: stable/wallaby branch of openstack/cinder is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/wallaby if you want to further work on this patch.