When restarting the c-bak service snapshot status is always backing-up

[ZhaoYixin]

When the volume is backed up by snapshot, restart the cinder-backup service at this time.
The snapshot status will not be rolled back to available, but will remain in backing-up.

[Sofia Enriquez (lsofia-enriquez)]

Greetings ZhaoYixin,

If I'm understanding correctly, restarting the c-bak service will make the snapshot stay at a backing-up state forever? This is interesting because as far as I know the backup service shouldn't impact snapshots.

Would you mind sharing more information in order to reproduce the issue easier?
- Steps to reproduce.
- Are you using a master or a stable version of cinder?
- What backend are you using? Currently, we have some issues regarding snapshots and generic NFS.
- Are you using encryption?

Cheers,
Sofia

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/806665

[Christian Rohmann (christian-rohmann)]

This looks valid as it's quite possible to create backups from a (volume) snapshot. So resetting their status on cinder-backup startup as well makes total sense.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/806665
Committed: https://opendev.org/openstack/cinder/commit/7f819854d26f103bc6358c7a27010a60588ec7c5
Submitter: "Zuul (22348)"
Branch: master

commit 7f819854d26f103bc6358c7a27010a60588ec7c5
Author: zhaoyixin <email address hidden>
Date: Tue Aug 31 10:21:28 2021 +0800

    Fix snapshot status is always backing-up

    This patch adds a snapshot clean operation in the
    cleanup_incomplete_backup_operations process of c-bak.

    Co-Authored-by: Christian Rohmann <email address hidden>
    Closes-Bug: #1938488
    Change-Id: Ifa3d572139fc37c94e3b50a02e61c9818a1b6501

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 25.0.0.0rc1 release candidate.