SVC _update_replication_properties for empty values

[nikeshkm]

Currently, inside method _update_replication_properties in cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py

        # Update model for replication
        if not rel_info:
            for key in rep_properties:
                if key in model_update['metadata']:
                    del model_update['metadata'][key]
        else:
            for key, value in rep_properties.items():
                if rel_info.get(value):
                    model_update['metadata'][key] = rel_info[value]

If, rel_info.get(value) is empty, then model_update['metadata'][key] will not be assigned empty value.

Example:
rel_info.get('sync') is '' , then model_update['metadata']['Sync'] will not be assigned ''.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/801617

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/801617
Committed: https://opendev.org/openstack/cinder/commit/da172417fffdf1d162319319fa34a73f2a597de1
Submitter: "Zuul (22348)"
Branch: master

commit da172417fffdf1d162319319fa34a73f2a597de1
Author: gksk <email address hidden>
Date: Wed Aug 18 17:02:28 2021 +0000

    [SVF] Fixed update_rep_properties for empty values

    [Spectrum Virtualize Family] During
    _update_replication_properties, some empty value
    volume relationship attributes of mirror volumes
    are not updated in volume metadata.

    Fixed the above issue by removing the check that filters
    only non-empty values of volume relationship properties.

    Closes-Bug: #1935670
    Change-Id: Ief710f5f337671c4aaf21899c69e3ccd62743d9e

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 19.0.0.0rc1 release candidate.