Deleting a reserved snapshot is missing detach.start notificacion

[Gorka Eguileor]

When we delete an attachment that is in the reserved state Cinder only issues the detach.end notification without the corresponding detach.start notification.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/778534
Committed: https://opendev.org/openstack/cinder/commit/68d49445778ef486e3ff656929405ab270a5a65d
Submitter: "Zuul (22348)"
Branch: master

commit 68d49445778ef486e3ff656929405ab270a5a65d
Author: Gorka Eguileor <email address hidden>
Date: Fri Jul 2 15:11:53 2021 +0200

    Fix detach notification

    Our current `attachment_delete` methods in the volume API and the
    manager are using DB methods directly, which makes the OVOs present in
    those methods get out of sync with the latest data, which leads to
    notifications having the wrong data when we send them on volume detach.

    This patch replaces DB method calls with OVO calls and moves the
    notification call to the end of the method, where we have the final
    status on the volume.

    It also adds the missing detach.start notification when deleting an
    attachment in the reserved state.

    Closes-Bug: #1916980
    Closes-Bug: #1935011
    Change-Id: Ie48cf55deacd08e7716201dac00ede8d57e6632f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/cinder/+/818883

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/cinder/+/824976

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/cinder/+/825100

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/824976
Committed: https://opendev.org/openstack/cinder/commit/c0197c6f1ad13e3a63615ceb667a53d3bbca2d77
Submitter: "Zuul (22348)"
Branch: stable/xena

commit c0197c6f1ad13e3a63615ceb667a53d3bbca2d77
Author: Gorka Eguileor <email address hidden>
Date: Fri Jul 2 15:11:53 2021 +0200

    Fix detach notification

    Our current `attachment_delete` methods in the volume API and the
    manager are using DB methods directly, which makes the OVOs present in
    those methods get out of sync with the latest data, which leads to
    notifications having the wrong data when we send them on volume detach.

    This patch replaces DB method calls with OVO calls and moves the
    notification call to the end of the method, where we have the final
    status on the volume.

    It also adds the missing detach.start notification when deleting an
    attachment in the reserved state.

    Closes-Bug: #1916980
    Closes-Bug: #1935011
    Change-Id: Ie48cf55deacd08e7716201dac00ede8d57e6632f
    (cherry picked from commit 68d49445778ef486e3ff656929405ab270a5a65d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/818883
Committed: https://opendev.org/openstack/cinder/commit/ed06fc7452699d76c22b288e1cc8e8bc2afa1849
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ed06fc7452699d76c22b288e1cc8e8bc2afa1849
Author: Gorka Eguileor <email address hidden>
Date: Fri Jul 2 15:11:53 2021 +0200

    Fix detach notification

    Our current `attachment_delete` methods in the volume API and the
    manager are using DB methods directly, which makes the OVOs present in
    those methods get out of sync with the latest data, which leads to
    notifications having the wrong data when we send them on volume detach.

    This patch replaces DB method calls with OVO calls and moves the
    notification call to the end of the method, where we have the final
    status on the volume.

    It also adds the missing detach.start notification when deleting an
    attachment in the reserved state.

    Closes-Bug: #1916980
    Closes-Bug: #1935011
    Change-Id: Ie48cf55deacd08e7716201dac00ede8d57e6632f
    (cherry picked from commit 68d49445778ef486e3ff656929405ab270a5a65d)
    Conflicts:
            cinder/volume/api.py
    Changes:
            cinder/volume/manager.py
    (cherry picked from commit c0197c6f1ad13e3a63615ceb667a53d3bbca2d77)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/825100
Committed: https://opendev.org/openstack/cinder/commit/c9d3cc966cc4856b9fcc8625ce3ce86061df1d87
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit c9d3cc966cc4856b9fcc8625ce3ce86061df1d87
Author: Gorka Eguileor <email address hidden>
Date: Fri Jul 2 15:11:53 2021 +0200

    Fix detach notification

    Our current `attachment_delete` methods in the volume API and the
    manager are using DB methods directly, which makes the OVOs present in
    those methods get out of sync with the latest data, which leads to
    notifications having the wrong data when we send them on volume detach.

    This patch replaces DB method calls with OVO calls and moves the
    notification call to the end of the method, where we have the final
    status on the volume.

    It also adds the missing detach.start notification when deleting an
    attachment in the reserved state.

    Closes-Bug: #1916980
    Closes-Bug: #1935011
    Change-Id: Ie48cf55deacd08e7716201dac00ede8d57e6632f
    (cherry picked from commit 68d49445778ef486e3ff656929405ab270a5a65d)
    Conflicts:
            cinder/volume/api.py
    Changes:
            cinder/volume/manager.py
    (cherry picked from commit c0197c6f1ad13e3a63615ceb667a53d3bbca2d77)
    (cherry picked from commit ed06fc7452699d76c22b288e1cc8e8bc2afa1849)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 19.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 18.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 17.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 20.0.0.0rc1 release candidate.