regression: availability_zone ignored in backup creation

[FengJiankui]

This was reported against victoria, but looks like the regression was introduced in ussuri by Change-Id: Ie2afb57c4861c41982612e6054767cef43fdb867

Step1 : create a backup A of a volume, value of availability_zone is nova1 in request
step2: availability_zone of backup A does not belong to nova1.

code in cinder/backup/api.py as floows:

             kwargs = {
                'user_id': context.user_id,
                'project_id': context.project_id,
                'display_name': name,
                'display_description': description,
                'volume_id': volume_id,
                'status': fields.BackupStatus.CREATING,
                'container': container,
                'parent_id': parent_id,
                'size': volume['size'],
                'snapshot_id': snapshot_id,
                'data_timestamp': data_timestamp,
                'parent': parent,
                'metadata': metadata or {}
            }
            backup = objects.Backup(context=context, **kwargs)
            backup.create()

availability_zone is not in kwargs.

[Brian Rosmaita (brian-rosmaita)]

Addressed by https://review.opendev.org/c/openstack/cinder/+/785099

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/785099
Committed: https://opendev.org/openstack/cinder/commit/ddcf394ae277692d7cab2e03b4b6ae67ba7f1cc3
Submitter: "Zuul (22348)"
Branch: master

commit ddcf394ae277692d7cab2e03b4b6ae67ba7f1cc3
Author: FengJiankui <email address hidden>
Date: Wed Apr 7 15:51:45 2021 +0800

    Do not ignore availability_zone in backup creation

    This patch corrects a regression introduced by change
    Ie2afb57c4861c4.

    Change-Id: I8b1b09ecf2ad1e19a557a664516251cae3ddf2ae
    Closes-Bug: #1912624

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/cinder/+/892352

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 23.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/cinder/+/916045

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/zed
Review: https://review.opendev.org/c/openstack/cinder/+/916045
Reason: stable/zed branch of openstack/cinder is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/zed if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/892352
Committed: https://opendev.org/openstack/cinder/commit/4ab3cbd7011b45d8d0f4acf4217688b6e2a26878
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 4ab3cbd7011b45d8d0f4acf4217688b6e2a26878
Author: FengJiankui <email address hidden>
Date: Wed Apr 7 15:51:45 2021 +0800

    Do not ignore availability_zone in backup creation

    This patch corrects a regression introduced by change
    Ie2afb57c4861c4.

    Change-Id: I8b1b09ecf2ad1e19a557a664516251cae3ddf2ae
    Closes-Bug: #1912624
    (cherry picked from commit ddcf394ae277692d7cab2e03b4b6ae67ba7f1cc3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 22.2.0 release.