Cinder

cinder manage API fails for some ipv6 NFS backends

Bug #1904892 reported by Eric Harney on 2020-11-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Cinder	Fix Released	Medium	Eric Harney

Bug Description

This will fail due to overly restrictive regex validation:
cinder manage hostgroup@cloud#[dead:beef::cafe]:/cinder01 vol-abcd

This is because validation for this call checks for a valid
hostname but needs to check for any string that would be a valid
"host" in Cinder, which is not the same thing.

Tags:

Eric Harney (eharney) on 2020-11-19

tags:	added: api validation
Changed in cinder:
assignee:	nobody → Eric Harney (eharney)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-11-19: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/763407

Changed in cinder:
status:	New → In Progress

michael-mcaleer (mmcaleer) on 2020-11-23

Changed in cinder:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-03-26: Fix included in openstack/cinder 18.0.0.0rc1

This issue was fixed in the openstack/cinder 18.0.0.0rc1 release candidate.

Eric Harney (eharney) on 2021-04-14

Changed in cinder:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-05: Fix proposed to cinder (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/cinder/+/789846

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-05: Fix merged to cinder (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/783204
Committed: https://opendev.org/openstack/cinder/commit/d5fed21fdfa754ca34d36ef5b0247394146bb961
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit d5fed21fdfa754ca34d36ef5b0247394146bb961
Author: Eric Harney <email address hidden>
Date: Thu Nov 19 11:21:57 2020 -0500

API validation: Add cinder_host type to support ipv6 in manage

This will fail due to overly restrictive regex validation:
cinder manage hostgroup@cloud#[dead:beef::cafe]:/cinder01 abcd

    This is because validation for this call checks for a valid
    hostname but needs to check for any string that would be a valid
    "host" in Cinder, which is not the same thing.

    Closes-Bug: #1904892
    Change-Id: I1349e8d3eb422f9dcd533c54f922f7ab8133b753
    (cherry picked from commit 8687925ce7b0e8f707006394f762a8f0a2ee60f3)
    (cherry picked from commit 51b92e9fa64baa3d362dd704ef064d042ef9541e)

tags:

added: in-stable-ussuri

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-06: Fix merged to cinder (stable/train)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/789846
Committed: https://opendev.org/openstack/cinder/commit/1644aab33b62adb2042ea709b685fc093e449ff0
Submitter: "Zuul (22348)"
Branch: stable/train

commit 1644aab33b62adb2042ea709b685fc093e449ff0
Author: Eric Harney <email address hidden>
Date: Thu Nov 19 11:21:57 2020 -0500

API validation: Add cinder_host type to support ipv6 in manage

This will fail due to overly restrictive regex validation:
cinder manage hostgroup@cloud#[dead:beef::cafe]:/cinder01 abcd

    This is because validation for this call checks for a valid
    hostname but needs to check for any string that would be a valid
    "host" in Cinder, which is not the same thing.