SolidFire driver fails to manage a volume by name

[Lucio Seki]

The SolidFire Cinder driver 'manage volume' feature is broken.
When I try to manage a previously unmanaged volume, the volume becomes in error state, and the driver prints error messages in cinder-volume log.

Steps to reproduce:
1. Set up a SolidFire back end
2. Create a volume
3. Write down the volume info to manage it back again
4. Unmnage the volume
5. Try to manage the volume

Expected result:
Have the volume managed successfully

Actual result:
The volume becomes in error state, and the driver prints an error message in cinder-volume log [0].

[0] http://paste.openstack.org/show/796910/

[Lucio Seki (lseki)]

Actually, the operation fails only when one tries to manage a volume by its volume-name, e.g.:

    cinder manage --id-type volume-name lucios-sandbox@sf#sf UUID-24df321d-8bfa-495e-bcd8-dc517e8ae528

The same happens when omitting --id-type parameter, as its default value is volume-name.

If source-id is specified instead, the manage operation succeeds, e.g.:

    cinder manage --id-type source-id lucios-sancbox@sf#sf 168

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/755101