Fix volume copy logic
Bug #1890979 reported by
haixin
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Cinder |
Incomplete
|
High
|
haixin | ||
Bug Description
when we migration, retype or backup an volume, it need to call _transfer_data function in volume_utils.py, especially in the RBD volume that we use a lot.
if the volume is thin volume, and the file in the volume is sparse file, this means it may not the end of file when we read b'',if we break here will lead to Incomplete file,This is a serious situation for mirror image。
so we should not break, we should continue and seek the offset of dest. in order to get the full data of src volume.
| Changed in cinder: | |
| assignee: | nobody → haixin (haixin77) |
| description: | updated |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix proposed to cinder (master) | #1 |
| Changed in cinder: | |
| status: | New → In Progress |
| Changed in cinder: | |
| importance: | Undecided → High |
| summary: |
- Optimize volume copy logic + Fix volume copy logic |
Revision history for this message
| Gorka Eguileor (gorka) wrote | #2 |
| Changed in cinder: | |
| status: | In Progress → Incomplete |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Change abandoned on cinder (master) | #3 |
To post a comment you must log in.
Fix proposed to branch: master
Review: https:/