Avoid get_pool_attrs in select_io_group for non hyperswap pools

Bug #1890588 reported by Chhavi Agarwal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
katari manoj kumar

Bug Description

currently select_io_group makes the get_pool_attrs each time, the pool_data fetched here is only required to verify for hyperswap enabled pools

We can have this call conditionally called if volume_topology is enabled for hyperswap

Changed in cinder:
assignee: nobody → katari manoj kumar (katarimanojkumar)
Eric Harney (eharney)
tags: added: drivers storwize
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/745576

Changed in cinder:
status: New → In Progress
Revision history for this message
katari manoj kumar (katarimanojkumar) wrote :
Revision history for this message
katari manoj kumar (katarimanojkumar) wrote :

This change is made to avoid unnecessary CLI calls that reduces the performance during bulk operations
My customer has negative impact due to these performance issues.
With this bugfix, time taken by group snapshot/clone operation for 100 non-hyperswap volumes reduced by 28 secs.

This change will also reduce time taken for creating non-hyperswap volumes.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/745576
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e554a61844800b61ceb4ddb4fc86ffb3d7f2ed37
Submitter: Zuul
Branch: master

commit e554a61844800b61ceb4ddb4fc86ffb3d7f2ed37
Author: katarimanojkumar <email address hidden>
Date: Mon Aug 10 19:07:27 2020 +0000

    [storwize]:Fixed select_io_group issues

    Fixed issues in select_io_group that impacts the performance during
    Create_volume, Group Snapshot/Clone operations for bulk
    non-hyperswap volumes.

    select_io_grp can avoid get_pool_attrs if the topology is not
    hyperswap.

    closes bug: #1890588

    Change-Id: Ibee878cfe86c82ad4c79247f2a3bd37f08be80b8

Changed in cinder:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.