PowerMAX Driver - incorrect snapshot deletion during do_sync_check

[Simon O'Donovan]

When performing _do_sync_check from a variety of operations snapshots associated with the volume being used will be deleted. This validation check should only be performing deletes against EMC_SMI and TEMP snapshots.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/741639

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/741639
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a7f9eda389344b43276fe1e5a54d5b7d8ab6c5a8
Submitter: Zuul
Branch: master

commit a7f9eda389344b43276fe1e5a54d5b7d8ab6c5a8
Author: odonos12 <email address hidden>
Date: Fri Jul 17 14:43:13 2020 +0100

    PowerMax Driver - Fix non-temporary snapshot delete

    Fix bug where non-temporary snapshots were being
    deleted from volume when do_sync_check is called
    for that volume, caused by missing check for
    temporary snapshot naming convention. Fixed by
    adding this check back into the conditional
    that determined if a snapshot should be deleted.

    Change-Id: I20194f57437e9ece5d95259bd91c95a4f19d9ab5
    Closes-Bug: 1887962

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/758543

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/758543
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=914548f70c4d278f1148ed13647e29314929b443
Submitter: Zuul
Branch: stable/victoria

commit 914548f70c4d278f1148ed13647e29314929b443
Author: odonos12 <email address hidden>
Date: Fri Jul 17 14:43:13 2020 +0100

    PowerMax Driver - Fix non-temporary snapshot delete

    Fix bug where non-temporary snapshots were being
    deleted from volume when do_sync_check is called
    for that volume, caused by missing check for
    temporary snapshot naming convention. Fixed by
    adding this check back into the conditional
    that determined if a snapshot should be deleted.

    Change-Id: I20194f57437e9ece5d95259bd91c95a4f19d9ab5
    Closes-Bug: 1887962
    (cherry picked from commit a7f9eda389344b43276fe1e5a54d5b7d8ab6c5a8)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/761193

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/761193
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=02ded3a9180eb4443f7f8227ab0f871f2d23cac5
Submitter: Zuul
Branch: stable/ussuri

commit 02ded3a9180eb4443f7f8227ab0f871f2d23cac5
Author: odonos12 <email address hidden>
Date: Fri Jul 17 14:43:13 2020 +0100

    PowerMax Driver - Fix non-temporary snapshot delete

    Fix bug where non-temporary snapshots were being
    deleted from volume when do_sync_check is called
    for that volume, caused by missing check for
    temporary snapshot naming convention. Fixed by
    adding this check back into the conditional
    that determined if a snapshot should be deleted.

    Change-Id: I20194f57437e9ece5d95259bd91c95a4f19d9ab5
    Closes-Bug: 1887962
    (cherry picked from commit a7f9eda389344b43276fe1e5a54d5b7d8ab6c5a8)
    (cherry picked from commit 914548f70c4d278f1148ed13647e29314929b443)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 17.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 16.2.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 18.0.0.0b1 development milestone.