Quota usage wrong when delete snapshot with volume retyped

[Nguyen Thanh Cong]

We have a volume and snapshot of this volume with volume type T1, and we retype this volume to a volume type T2. At this time, volume and snapshot have different volume type. And then we delete the snapshot and check quota usage of project and it wrong! When i delete snapshot it subtract quota usage of volume type T2.

Step to reproduce:
- Create volume volume type T1
- Create snapshot of volume
- Retype volume to volume type T2
- Delete snapshot or delete volume with cascade
---

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/725951

[Nguyen Thanh Cong (congnt95)]

can anyone can review code for me?

[Gorka Eguileor (gorka)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/781515

This fix is different than the other one and both can work together.
In this patch we make the snapshots retype with the volume.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 18.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 19.0.0.0b1 development milestone.