Cinder

PowerMax Driver - Failover lock not released during U4P failover during exception

Bug #1875640 reported by Simon O'Donovan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Simon O'Donovan

Bug Description

Potential deadlock scenario in rest.py request if more than one operation is launched. The first operation will set a failover_lock putting any new requests into a wait loop. If the first operation encounters an exception it will not clear the failover_lock resulting in the remaining requests waiting indefinitely.

Simon O'Donovan (odonos12)
Changed in cinder:
assignee: nobody → Simon O'Donovan (odonos12)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/723908

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/723908
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4351ace84f4ffd87d78a58fac3dd2eda64d41ba1
Submitter: Zuul
Branch: master

commit 4351ace84f4ffd87d78a58fac3dd2eda64d41ba1
Author: odonos12 <email address hidden>
Date: Tue Apr 28 13:33:20 2020 +0100

    PowerMax Driver - U4P failover lock not released on exception

    During U4P failover, if the initial operation that triggered the
    failover hits an exception it can leave the failover lock in place.
    Any operations waiting for lock to clear will continue to loop in place.
    Added additional lock releases in exception catches and also a maximum
    time that the holding operations should wait.

    Change-Id: I43319854df9597df791a83cb4c598db0db3caec7
    Closes-bug: 1875640

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/729217

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/ussuri)

Reviewed: https://review.opendev.org/729217
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=13e45234bf7ce8042e35d609267aef34877e5b0e
Submitter: Zuul
Branch: stable/ussuri

commit 13e45234bf7ce8042e35d609267aef34877e5b0e
Author: odonos12 <email address hidden>
Date: Tue Apr 28 13:33:20 2020 +0100

    PowerMax Driver - U4P failover lock not released on exception

    During U4P failover, if the initial operation that triggered the
    failover hits an exception it can leave the failover lock in place.
    Any operations waiting for lock to clear will continue to loop in place.
    Added additional lock releases in exception catches and also a maximum
    time that the holding operations should wait.

    Change-Id: I43319854df9597df791a83cb4c598db0db3caec7
    Closes-bug: 1875640
    (cherry picked from commit 4351ace84f4ffd87d78a58fac3dd2eda64d41ba1)

tags: added: in-stable-ussuri
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.