NEC driver: creating volumes from an image volume in parallel failed.

[Naoki Saito]

With NEC driver, when the volumes were created from the same image in 4 parallels or more it gives following error message
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server [req-04f8d45d-0759-4a1c-a847-46042d4054b2 67c293d93a344c09a328f2caa3104012 602c841915ce4287988e9695801a38dd - - -] Exception during message handling: UnboundLocalError: local variable 'msg' referenced before assignment
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server Traceback (most recent call last):
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 163, in _process_incoming
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 220, in dispatch
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 190, in _do_dispatch
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "<string>", line 2, in create_volume
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/objects/cleanable.py", line 207, in wrapper
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server result = f(*args, **kwargs)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/volume/manager.py", line 690, in create_volume
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server _run_flow()
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/volume/manager.py", line 682, in _run_flow
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server flow_engine.run()
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/taskflow/engines/action_engine/engine.py", line 247, in run
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server for _state in self.run_iter(timeout=timeout):
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/taskflow/engines/action_engine/engine.py", line 340, in run_iter
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server failure.Failure.reraise_if_any(er_failures)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/taskflow/types/failure.py", line 336, in reraise_if_any
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server failures[0].reraise()
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/taskflow/types/failure.py", line 343, in reraise
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server six.reraise(*self._exc_info)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/taskflow/engines/action_engine/executor.py", line 53, in _execute_task2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server result = task.execute(**arguments)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/volume/flows/manager/create_volume.py", line 1020, in execute
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server **volume_spec)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/volume/flows/manager/create_volume.py", line 929, in _create_from_image
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server image_service)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/volume/flows/manager/create_volume.py", line 793, in _create_from_image_cache_or_download
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server image_meta
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/volume/flows/manager/create_volume.py", line 706, in _create_from_image_cache
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server cache_entry['volume_id']
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/volume/flows/manager/create_volume.py", line 492, in _create_from_source_volume
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server model_update = self.driver.create_cloned_volume(volume, srcvol_ref)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/volume/drivers/nec/volume_helper.py", line 441, in create_cloned_volume
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server self._create_cloned_volume(volume, src_vref)
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/volume/drivers/nec/volume_helper.py", line 479, in _create_cloned_volume
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server {'msg': msg, 'ldname': source_name})
2019-10-24 15:19:20.536 15218 ERROR oslo_messaging.rpc.server UnboundLocalError: local variable 'msg' referenced before assignment

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/692528

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/696439

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/696439
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=41cf3b749797425d5ddd6cb93109299e14224b3a
Submitter: Zuul
Branch: stable/train

commit 41cf3b749797425d5ddd6cb93109299e14224b3a
Author: Naoki Saito <email address hidden>
Date: Fri Nov 1 20:03:12 2019 +0900

    NEC driver: fix an undefined variable

    Currently, NEC driver references an undefined variable in message
    formatting.
    That causes volume creation failure when 4 or more volumes are created
    from same image in parallel.

    This patch removes the reference.

    Change-Id: I3dc6a55ee5ed496a37885a139fba11d1134e971f
    Closes-Bug: #1850913
    (cherry picked from commit 16dbad18ccb98e1e89dc9d1d2369fdb893d855b0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 15.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 16.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/708562

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/708562
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=16f9c5535faddba127214a57b5626f1b9795a673
Submitter: Zuul
Branch: stable/stein

commit 16f9c5535faddba127214a57b5626f1b9795a673
Author: Naoki Saito <email address hidden>
Date: Fri Nov 1 20:03:12 2019 +0900

    NEC driver: fix an undefined variable

    Currently, NEC driver references an undefined variable in message
    formatting.
    That causes volume creation failure when 4 or more volumes are created
    from same image in parallel.

    This patch removes the reference.

    Conflicts:
            cinder/tests/unit/volume/drivers/nec/test_volume.py
            Note: It is refactored in Train.

    Change-Id: I3dc6a55ee5ed496a37885a139fba11d1134e971f
    Closes-Bug: #1850913
    (cherry picked from commit 16dbad18ccb98e1e89dc9d1d2369fdb893d855b0)
    (cherry picked from commit 41cf3b749797425d5ddd6cb93109299e14224b3a)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/713347

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 14.0.4 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/713347
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d0e9c22bee5e5eedc4d86e0c1e3986baedf94507
Submitter: Zuul
Branch: stable/rocky

commit d0e9c22bee5e5eedc4d86e0c1e3986baedf94507
Author: Naoki Saito <email address hidden>
Date: Fri Nov 1 20:03:12 2019 +0900

    NEC driver: fix an undefined variable

    Currently, NEC driver references an undefined variable in message
    formatting.
    That causes volume creation failure when 4 or more volumes are created
    from same image in parallel.

    This patch removes the reference.

    Conflicts:
            cinder/tests/unit/volume/drivers/nec/test_volume.py
            Note: It is refactored in Train.

    Change-Id: I3dc6a55ee5ed496a37885a139fba11d1134e971f
    Closes-Bug: #1850913
    (cherry picked from commit 16dbad18ccb98e1e89dc9d1d2369fdb893d855b0)
    (cherry picked from commit 41cf3b749797425d5ddd6cb93109299e14224b3a)
    (cherry picked from commit 16f9c5535faddba127214a57b5626f1b9795a673)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/720625

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/720625
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c394a84372b83ae29b4f70dfb887a6c71ea446b7
Submitter: Zuul
Branch: stable/queens

commit c394a84372b83ae29b4f70dfb887a6c71ea446b7
Author: Naoki Saito <email address hidden>
Date: Fri Nov 1 20:03:12 2019 +0900

    NEC driver: fix an undefined variable

    Currently, NEC driver references an undefined variable in message
    formatting.
    That causes volume creation failure when 4 or more volumes are created
    from same image in parallel.

    This patch removes the reference.

    Conflicts:
            cinder/tests/unit/volume/drivers/nec/test_volume.py
            Note: It is refactored in Train.

    Change-Id: I3dc6a55ee5ed496a37885a139fba11d1134e971f
    Closes-Bug: #1850913
    (cherry picked from commit 16dbad18ccb98e1e89dc9d1d2369fdb893d855b0)
    (cherry picked from commit 41cf3b749797425d5ddd6cb93109299e14224b3a)
    (cherry picked from commit 16f9c5535faddba127214a57b5626f1b9795a673)
    (cherry picked from commit d0e9c22bee5e5eedc4d86e0c1e3986baedf94507)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder rocky-eol release.