os-volume_upload_image action uses stale metadata

[Brian Rosmaita]

Under some circumstances, the os-volume_upload_image action uses stale metadata. This can occur when the volume being uploaded has itself been created from an image. In this case, the volume will have the old properties stored in the volume_glance_metadata table, and these properties will be transferred to the new image being uploaded. In some flows, however, new values are assigned to image properties (for example, when the volume is encrypted). If these same image properties are present in the volume_glance_metadata table, the new values are overwritten with the stale properties in the table.

I'll put up a patch so you can see this in action before I post a patch with a fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/683235

[Brian Rosmaita (brian-rosmaita)]

https://review.opendev.org/#/c/683235/1 adds a new test that shows the bug (it fails, of course).

[Brian Rosmaita (brian-rosmaita)]

Latest patch contains the fix (and is passing).

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/683235
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ecf7041adacde3764082de7fba5ae82f22d48309
Submitter: Zuul
Branch: master

commit ecf7041adacde3764082de7fba5ae82f22d48309
Author: Brian Rosmaita <email address hidden>
Date: Thu Sep 19 16:16:00 2019 -0400

    Make sure stale image metadata is not used

    When uploading a volume to an image, Cinder checks to see if there's
    any image metadata already present on the volume, and if so, it adds
    it to the image-create request so that Glance will persist these
    additional properties on the new image. If during upload preparation,
    Cinder wants to add specific metadata to the new image (for example,
    a new encryption key id), we need to ensure that the new value for
    this property is preferred to a value in the volume_glance_metadata
    table.

    Closes-bug: #1844725

    Change-Id: Iba3c5fa4db87641a84eb22a0fc93294dd55a3132

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 15.0.0.0rc1 release candidate.