cinder.tests.unit.compute.test_nova.NovaClientTestCase.test_novaclient_exceptions breaks with novaclient 15.0.0

Bug #1842440 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
Matt Riedemann

Bug Description

Seen in the upper-constraints change to use novaclient 15.0.0:

https://review.opendev.org/#/c/679295/

https://8f7ecd6c133f5945c44f-888e5d5194de3968ae2aa6fe2799c1a7.ssl.cf2.rackcdn.com/679295/2/check/cross-cinder-py27/a6fbb6d/testr_results.html.gz

ft1.2: cinder.tests.unit.compute.test_nova.NovaClientTestCase.test_novaclient_exceptions_StringException: pythonlogging:'': {{{
2019-09-02 21:56:21,522 INFO [keystonemiddleware.auth_token] Starting Keystone auth_token middleware
2019-09-02 21:56:21,526 WARNING [keystonemiddleware._common.config] The option "auth_url" is not known to keystonemiddleware
2019-09-02 21:56:21,527 WARNING [keystonemiddleware.auth_token] AuthToken middleware is set with keystone_authtoken.service_token_roles_required set to False. This is backwards compatible but deprecated behaviour. Please set this to True.
2019-09-02 21:56:21,531 WARNING [keystonemiddleware.auth_token] Configuring www_authenticate_uri to point to the public identity endpoint is required; clients may not be able to authenticate against an admin endpoint
}}}

Traceback (most recent call last):
  File "cinder/tests/unit/compute/test_nova.py", line 178, in test_novaclient_exceptions
    self.assertTrue(hasattr(nova_exceptions, 'EndpointNotFound'))
  File "cinder/test.py", line 442, in assertTrue
    self.assertIs(True, x, *args, **kwargs)
  File "/home/zuul/src/opendev.org/openstack/cinder/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 445, in assertIs
    self.assertThat(observed, matcher, message)
  File "/home/zuul/src/opendev.org/openstack/cinder/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: False is not True

This is due to this change:

https://github.com/openstack/python-novaclient/commit/81ec72ecf8c32b409afedc60e013f9b4c47d5bae#diff-2ec4a4c853e7685ad4334b670e126c3cL73

Removing the EndpointNotFound exception class in 15.0.0.

Matt Riedemann (mriedem)
Changed in cinder:
assignee: nobody → Matt Riedemann (mriedem)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/679802

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/679802
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3cef55907b1c7fe273a9972f82a512a6ce2286bd
Submitter: Zuul
Branch: master

commit 3cef55907b1c7fe273a9972f82a512a6ce2286bd
Author: Matt Riedemann <email address hidden>
Date: Tue Sep 3 10:58:59 2019 -0400

    nova: use EndpointNotFound from keystoneauth1

    I16e0b6e55a9c9da04c4582f9be672018d37bf368 in python-novaclient 15.0.0
    removed the EndpointNotFound class which breaks the cinder unit
    test "test_novaclient_exceptions". That test was added with change
    Iea3ff0405ef8cf9c5222a489d85f9d135ebd3652 in Ocata after novaclient
    7.0.0 removed its service catalog code. The cinder novaclient module
    code was updated in I55613793c8f525a36ac74636f47d7ab76f5c7e39 (Pike)
    and Ie27f3b528dbfaa57fe354a84a93787e1618182a3 (Pike) to remove the
    hacked service catalog code but still checks the service catalog for
    an identity endpoint if cinder isn't configured with an auth_url for
    talking to nova. That code was raising novaclient.EndpointNotFound
    which is now gone, so this change swaps it to use EndpointNotFound
    from the keystoneauth1 library instead.

    Needed by: https://review.opendev.org/679295/

    Change-Id: I4b03beba0f847d779b6f3031be7ac68925cc79f4
    Closes-Bug: #1842440

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 15.0.0.0rc1

This issue was fixed in the openstack/cinder 15.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers