NetApp SolidFire replication errors

[Erlon R. Cruz]

Cinder Replication on SolidFire driver does not work as expected. During some tests we have found the following problems:

- Driver can't restart if replication is configured;
- Replication status on volumes is always shown as None;
- Snapshots are not replicated, remote replication is not set for snapshots of a given volume;
- Create from snapshot does not work (volumes created from a snapshot are not replicated);
- Create from volume does not work (volumes created from another volume are not replicated);
- Manage/Unmanage does not work;
- Group replication does not work and should properly inform users about that;
- Failover hangs if the source cluster is offline;

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/675630

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675630
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=215d6b2b272847d695c5c5d17c9d387e123b1396
Submitter: Zuul
Branch: master

commit 215d6b2b272847d695c5c5d17c9d387e123b1396
Author: Erlon R. Cruz <email address hidden>
Date: Wed Jul 24 17:40:33 2019 -0300

    NetApp SolidFire: Fix replication

    This patch addresses several of the problems currently found in this
    driver:

     - When creating a SolidFire volume with a volume type that has
    replication enabled the replication_status of this volume was not
    changing.
     - During initialization, if a cluster is already paired, the driver
    fails to load.
     - Driver does not create volumes on the replication target on
    several configurations. For example, if the volume is being
    created from a snashot or from another volume, etc.
     - During Failback, the driver doesn't update iSCSI connection
    info to the secondary cluster nor the volume's replication status.

    Closes-bug: #1834013
    Closes-bug: #1751932
    Change-Id: I920f958db1d48e52b548082d852c03f427a279ca
    Co-Authored-By: Fernando Ferraz <email address hidden>
    Co-Authored-By: Thiago Correa <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/686519

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/686519
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7b227c647d5d81c1ae9e54b0e5fd76cc07c73257
Submitter: Zuul
Branch: stable/train

commit 7b227c647d5d81c1ae9e54b0e5fd76cc07c73257
Author: Erlon R. Cruz <email address hidden>
Date: Wed Jul 24 17:40:33 2019 -0300

    NetApp SolidFire: Fix replication

    This patch addresses several of the problems currently found in this
    driver:

     - When creating a SolidFire volume with a volume type that has
    replication enabled the replication_status of this volume was not
    changing.
     - During initialization, if a cluster is already paired, the driver
    fails to load.
     - Driver does not create volumes on the replication target on
    several configurations. For example, if the volume is being
    created from a snashot or from another volume, etc.
     - During Failback, the driver doesn't update iSCSI connection
    info to the secondary cluster nor the volume's replication status.

    Closes-bug: #1834013
    Closes-bug: #1751932
    Change-Id: I920f958db1d48e52b548082d852c03f427a279ca
    Co-Authored-By: Fernando Ferraz <email address hidden>
    Co-Authored-By: Thiago Correa <email address hidden>
    (cherry picked from commit 215d6b2b272847d695c5c5d17c9d387e123b1396)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 15.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 16.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/729657

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/729657
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5fec81daa6b0cd694bb8987abdd88e0e6106bdfc
Submitter: Zuul
Branch: stable/stein

commit 5fec81daa6b0cd694bb8987abdd88e0e6106bdfc
Author: Erlon R. Cruz <email address hidden>
Date: Wed Jul 24 17:40:33 2019 -0300

    NetApp SolidFire: Fix replication

    This patch addresses several of the problems currently found in this
    driver:

     - When creating a SolidFire volume with a volume type that has
    replication enabled the replication_status of this volume was not
    changing.
     - During initialization, if a cluster is already paired, the driver
    fails to load.
     - Driver does not create volumes on the replication target on
    several configurations. For example, if the volume is being
    created from a snashot or from another volume, etc.
     - During Failback, the driver doesn't update iSCSI connection
    info to the secondary cluster nor the volume's replication status.

    Closes-bug: #1834013
    Closes-bug: #1751932
    Change-Id: I920f958db1d48e52b548082d852c03f427a279ca
    Co-Authored-By: Fernando Ferraz <email address hidden>
    Co-Authored-By: Thiago Correa <email address hidden>
    (cherry picked from commit 215d6b2b272847d695c5c5d17c9d387e123b1396)
    (cherry picked from commit 7b227c647d5d81c1ae9e54b0e5fd76cc07c73257)