Unity: force-delete not delete volumes in storage groups

[Ryan Liang]

This bug is originally reported on RH BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1635354

COPIED FROM BZ

Description of problem:
On VNX backend, a setting called force_delete_lun_in_storagegroup tells cinder to always remove the LUN from storagegroup before destroying it. We could expect that when a user runs "cinder force-delete", it should do that no matter what that setting is set to.

If other storages have a force-delete function, it should probably get called the same way.

We know that cinder force-delete just skips the volume's state validation at this point.

Version-Release number of selected component (if applicable):
openstack-cinder-12.0.3-2.el7ost.noarch

How reproducible:
All the time

Steps to Reproduce:
1. Have a volume in error_deleting
2. Make sure that force_delete_lun_in_storagegroup is set to false
~~~
crudini --set /var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf tripleo_vnx force_delete_lun_in_storagegroup False
~~~

3. cinder force-delete

Actual results:
Volume is not deleted

Expected results:
Volume should be deleted

Additional info:
force_delete_lun_in_storagegroup should only affect the default behavior of "cinder delete"

[Ryan Liang (ryan-liang)]

The fix needs to modify the Cinder framework and VNX driver codes.

I registered a BP for this: https://blueprints.launchpad.net/cinder/+spec/pass-force-delete-to-driver

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/653912

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/665281

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ryan Liang (<email address hidden>) on branch: master
Review: https://review.opendev.org/653912
Reason: New review is: https://review.opendev.org/#/c/665281/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665281
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=850013325b50e890ad240c360c782731e6b98a56
Submitter: Zuul
Branch: master

commit 850013325b50e890ad240c360c782731e6b98a56
Author: Ryan Liang <email address hidden>
Date: Fri Jun 14 10:50:12 2019 +0800

    Unity: force delete lun by default

    The option `force_delete_lun_in_storagegroup` was set to `False` by
    default before. Customers should change it to `True` in `cinder.conf` to
    make sure luns can be deleted even when they are still in storage
    groups.

    This fix enables the option's default value to `True`.

    Change-Id: I5507d280a5a68debd1f055988aa8c233b2147d09
    Closes-bug: #1825469

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 15.0.0.0rc1 release candidate.