Cinder's new attach API all volume in creating status to be attached

[Yang Zhang]

The new cinder attach api allows volumes in status other than 'available', 'in-use', 'downloading' to be attached.
This may cause issues when attaching creating volumes or volumes in other status.
If we had some problems with a volume driver, the wolume got stuck in creating status. Then we use nova volume-attach cmd to attach this volume to an instance with the new cinder attach api (versions after CINDER_V3_ATTACH_MIN_COMPUTE_VERSION), the volume will change to available status via "volume_api.attachment_delete". This status is out of sync with the real status in the volume backend.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/633177

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/633177
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=6eba403ba020292806d0ec35edc7964eaa8e8eaf
Submitter: Zuul
Branch: master

commit 6eba403ba020292806d0ec35edc7964eaa8e8eaf
Author: zhangyang <email address hidden>
Date: Fri Jan 25 18:11:17 2019 +0800

    Create volume attachments status check.

    Currently the new cinder attachment_create method allows volumes in
    all status to be performed for single attachment. This may cause
    problems if volume-attach operation is taken on volumes in creating
    status.
    In order to avoid these problems, we should only allow volumes
    in 'in-use', 'reserved' status to check whether this attachment
    creation is a override operation for a same instance.

    Related-bug: #1694530
    Change-Id: Ie59f609d38290147a67a936c61e0164fe278da99
    Closes-Bug: #1813267

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.