SolidFire driver does not work with python3

Bug #1813189 reported by Erlon R. Cruz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Thiago Correa

Bug Description

The SolidFire driver crashes when executing in python3 in the following function:
def _get_account_create_availability(self, accounts)
...
This happens because python3 does not allow the comparison between a list and an integer as it is in this statement:
if self._get_volumes_for_account(acc['accountID']) > self.max_volumes_per_account:
It's also needed to check the logic and the need of this if statement, this block is, logically, never executed:
if len(accounts) == 1:
sfaccount = self._create_sfaccount(accounts[0]['name'] + '_')
return sfaccount

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/633596

Changed in cinder:
assignee: nobody → Thiago Correa (thgcorrea)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/633596
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4a2230919476ddc38ff1a8602b202f4ded128513
Submitter: Zuul
Branch: master

commit 4a2230919476ddc38ff1a8602b202f4ded128513
Author: Thiago Correa <email address hidden>
Date: Wed Feb 6 12:53:07 2019 -0200

    NetApp SolidFire: Fix misbehavior on account creation

    This change fixes a misbehavior when creating a new sfaccount and
    verifying the availability for new sfaccounts. It also fixes
    the driver compability with python3.

    Change-Id: I35cd8d0725aad36e97becb5599b7eaf6c413f2e3
    Closes-bug: #1813189

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 14.0.0.0rc1

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.