Support Incremental Backup Completion In RBD

[wanghao]

Ceph RBD backend ignores the `--incremental` option when creating a volume
backup. The first backup of a given volume is always a full backup,
and each subsequent backup is always an incremental backup. This behavior
makes it impossible to remove old backups while keeping at least one recent backup.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/627941

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/627941
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5018727f8e18992e64c55b84f0d5b39ae7c70b32
Submitter: Zuul
Branch: master

commit 5018727f8e18992e64c55b84f0d5b39ae7c70b32
Author: wanghao <email address hidden>
Date: Wed Jan 2 16:24:26 2019 +0800

    Support Incremental Backup Completion In RBD

    Ceph RBD backend ignores the `--incremental` option when creating a
    volume backup. The first backup of a given volume is always a full
    backup, and each subsequent backup is always an incremental backup.
    This behavior makes it impossible to remove old backups while
    keeping at least one recent backup.

    Since Cinder will not find the latest_backup id as parent_id if
    '--incremental=False', so we can use the parent_id to ensure
    whether do the full backup in rbd driver or not.

    If the incremental flag '--incremental' is not specified, this
    patch will always create a new full backup for rbd volume.

    Change-Id: I516b7c82b05b26e81195f7f106d43a9e0804082d
    Closes-Bug: #1810270
    Closes-Bug: #1790713
    Co-Authored-By: Sofia Enriquez <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 15.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/704876

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/704877

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/705553

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sofia Enriquez (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/704876
Reason: Abandon because the Change-Id is wrong. Continue here https://review.opendev.org/705553/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/705703

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sofia Enriquez (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/704877
Reason: Wrong change-id continue in https://review.opendev.org/#/c/705703/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/705553
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=bef90868971118dcced47a64f3bbffc7f2732db7
Submitter: Zuul
Branch: stable/stein

commit bef90868971118dcced47a64f3bbffc7f2732db7
Author: wanghao <email address hidden>
Date: Wed Jan 2 16:24:26 2019 +0800

    Support Incremental Backup Completion In RBD

    Ceph RBD backend ignores the `--incremental` option when creating a
    volume backup. The first backup of a given volume is always a full
    backup, and each subsequent backup is always an incremental backup.
    This behavior makes it impossible to remove old backups while
    keeping at least one recent backup.

    Since Cinder will not find the latest_backup id as parent_id if
    '--incremental=False', so we can use the parent_id to ensure
    whether do the full backup in rbd driver or not.

    If the incremental flag '--incremental' is not specified, this
    patch will always create a new full backup for rbd volume.

    Closes-Bug: #1810270
    Closes-Bug: #1790713
    Co-Authored-By: Wanghao <email address hidden>
    Co-Authored-By: Sofia Enriquez <email address hidden>
    (cherry picked from commit 5018727f8e18992e64c55b84f0d5b39ae7c70b32)

    Conflicts:
     cinder/tests/unit/backup/drivers/test_backup_ceph.py
    Change-Id: I516b7c82b05b26e81195f7f106d43a9e0804082d

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/705703
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=bce6d01e153100681540d29496d2332c45b53eb3
Submitter: Zuul
Branch: stable/rocky

commit bce6d01e153100681540d29496d2332c45b53eb3
Author: wanghao <email address hidden>
Date: Wed Jan 2 16:24:26 2019 +0800

    Support Incremental Backup Completion In RBD

    Ceph RBD backend ignores the `--incremental` option when creating a
    volume backup. The first backup of a given volume is always a full
    backup, and each subsequent backup is always an incremental backup.
    This behavior makes it impossible to remove old backups while
    keeping at least one recent backup.

    Since Cinder will not find the latest_backup id as parent_id if
    '--incremental=False', so we can use the parent_id to ensure
    whether do the full backup in rbd driver or not.

    If the incremental flag '--incremental' is not specified, this
    patch will always create a new full backup for rbd volume.

    Closes-Bug: #1810270
    Closes-Bug: #1790713
    Co-Authored-By: Wanghao <email address hidden>
    Co-Authored-By: Sofia Enriquez <email address hidden>
    (cherry picked from commit 5018727f8e18992e64c55b84f0d5b39ae7c70b32)

    Conflicts:
     cinder/tests/unit/backup/drivers/test_backup_ceph.py
    Change-Id: I516b7c82b05b26e81195f7f106d43a9e0804082d
    (cherry picked from commit 6cc8adb132b91be68c0b22c750417efb97f08ce0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 13.0.9 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 14.0.4 release.