Cinder

UPDATE_ADMIN_METADATA_POLICY is redundant and useless

Bug #1809519 reported by Yikun Jiang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
In Progress
Undecided
Yikun Jiang

Bug Description

The UPDATE_ADMIN_METADATA_POLICY is a redundant and useless policy.

Cinder already has "UPDATE_READONLY_POLICY" to authorize "os-update_readonly_flag" api policy [1] and "ATTACH_POLICY" to authorize "os-attach" policy [2].

Also, there is no update admin metadata api in Cinder.

So the policy check [3] in the update_volume_admin_metadata method (will only called by os-update_readonly_flag and os-attach) is useless.

[1] https://github.com/openstack/cinder/blob/7d7dc26/cinder/volume/api.py#L1592
[2] https://github.com/openstack/cinder/blob/7d7dc26/cinder/volume/api.py#L759
[3] https://github.com/openstack/cinder/blob/7d7dc26/cinder/volume/api.py#L1181

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/627028

Changed in cinder:
assignee: nobody → Yikun Jiang (yikunkero)
status: New → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.