MSA 2050 is not registered

[Jonghan]

In case of HP MSA 2050 storage, response data of login API is different from that of MSA 2040.
Please take look at the 'response-type'.

[MSA 2040]
# curl --insecure https://192.168.111.22/api/login/539e12f63b693a9970a97b885e857f8b
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<RESPONSE>
 <OBJECT basetype="status" name="status" oid="1">
  <PROPERTY name="response-type">success</PROPERTY>
  <PROPERTY name="response-type-numeric">0</PROPERTY>
  <PROPERTY name="response">28f958fd88fd6e2acd7201624f7f8a82</PROPERTY>
  <PROPERTY name="return-code">1</PROPERTY>
 </OBJECT>
</RESPONSE>

[MSA 2050]
# curl --insecure https://107.250.209.17/api/login/539e12f63b693a9970a97b885e857f8b
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<RESPONSE VERSION="L100">
  <OBJECT basetype="status" name="status" oid="1">
    <PROPERTY name="response-type" type="string" size="12" draw="false" sort="nosort" display-name="Response Type">Success</PROPERTY>
    <PROPERTY name="response-type-numeric" type="uint32" size="12" draw="false" sort="nosort" display-name="Response Type">0</PROPERTY>
    <PROPERTY name="response" type="string" size="180" draw="true" sort="nosort" display-name="Response">79ea8ac277e1a4491ec7f6e9e6c0431b</PROPERTY>
    <PROPERTY name="return-code" type="sint32" size="15" draw="false" sort="nosort" display-name="Return Code">1</PROPERTY>
    <PROPERTY name="component-id" type="string" size="80" draw="false" sort="nosort" display-name="Component ID"></PROPERTY>
    <PROPERTY name="time-stamp" type="string" size="25" draw="false" sort="datetime" display-name="Time">2018-12-14 06:31:33</PROPERTY>
    <PROPERTY name="time-stamp-numeric" type="uint32" size="25" draw="false" sort="datetime" display-name="Time">1544769093</PROPERTY>
  </OBJECT>
</RESPONSE>

Cinder volume tries to check login result using 'response-type' PROPERTY and compare it with 'success' so MSA 2050 is always failed to login.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/626104

[Jonghan (forhim-park)]

When I test this issue using another 'MSA 2050', return format is same as that of MSA 2040.
So, I think, this is storage issue.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jonghan Park (<email address hidden>) on branch: master
Review: https://review.openstack.org/626104
Reason: It looks storage issue.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/631699

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/631699
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0565732a161ccc8bbef729019f7a24f2d862e606
Submitter: Zuul
Branch: master

commit 0565732a161ccc8bbef729019f7a24f2d862e606
Author: Chris M <email address hidden>
Date: Fri Jan 18 02:13:21 2019 +0000

    Fix for HPE MSA 2050 login failures

    When authenticating to the array, use the 'response-type-numeric'
    value to determine success, rather than doing a string match against the
    'response-type' string, which is not guaranteed to be consistent.

    Change-Id: I47fe1ff2dd5e24fffd5118aeab9473774eb58a61
    Closes-Bug: #1808968

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/636433

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/637941

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/636433
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=883b29cf46e3248ce9cc4061d8312343c20c8192
Submitter: Zuul
Branch: stable/rocky

commit 883b29cf46e3248ce9cc4061d8312343c20c8192
Author: Chris M <email address hidden>
Date: Fri Jan 18 02:13:21 2019 +0000

    Fix for HPE MSA 2050 login failures

    When authenticating to the array, use the 'response-type-numeric'
    value to determine success, rather than doing a string match against the
    'response-type' string, which is not guaranteed to be consistent.

    Change-Id: I47fe1ff2dd5e24fffd5118aeab9473774eb58a61
    Closes-Bug: #1808968
    (cherry picked from commit 0565732a161ccc8bbef729019f7a24f2d862e606)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/637941
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f712fabbec0a2d767a20adb23d05a75736732367
Submitter: Zuul
Branch: stable/queens

commit f712fabbec0a2d767a20adb23d05a75736732367
Author: Chris M <email address hidden>
Date: Fri Jan 18 02:13:21 2019 +0000

    Fix for HPE MSA 2050 login failures

    When authenticating to the array, use the 'response-type-numeric'
    value to determine success, rather than doing a string match against the
    'response-type' string, which is not guaranteed to be consistent.

    Change-Id: I47fe1ff2dd5e24fffd5118aeab9473774eb58a61
    Closes-Bug: #1808968
    (cherry picked from commit 0565732a161ccc8bbef729019f7a24f2d862e606)
    (cherry picked from commit 883b29cf46e3248ce9cc4061d8312343c20c8192)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/644945

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 13.0.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 12.0.6 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/644945
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9bf444b869d35b56e48be8b4a8a84fddb81467c6
Submitter: Zuul
Branch: stable/pike

commit 9bf444b869d35b56e48be8b4a8a84fddb81467c6
Author: Chris M <email address hidden>
Date: Fri Jan 18 02:13:21 2019 +0000

    Fix for HPE MSA 2050 login failures

    When authenticating to the array, use the 'response-type-numeric'
    value to determine success, rather than doing a string match against the
    'response-type' string, which is not guaranteed to be consistent.

    Change-Id: I47fe1ff2dd5e24fffd5118aeab9473774eb58a61
    Closes-Bug: #1808968
    (cherry picked from commit 0565732a161ccc8bbef729019f7a24f2d862e606)
    (cherry picked from commit 883b29cf46e3248ce9cc4061d8312343c20c8192)
    (cherry picked from commit f712fabbec0a2d767a20adb23d05a75736732367)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.2.2 release.