The time to send 'attach.end' notify is unexpected

[Yikun Jiang]

The 'attach.end' notify should be sent after the volume is changed to 'in-used', but now is sent in attachment_update (the volume is 'attaching'), we should move this notify to "attachment_complete".

Since microversion 3.44[1], we add a new api interface 'attachment_complete'.

There are 3 status in new attachement flow:
1. reserved
     We've created an empty attachment record but haven't done anything
     with it yet.
2. attaching
     We provided a connector and set up the TGT so that everything is
     ready for a consumer to connect/use it.
3. in-use
     An ACK back from the consumer letting us know that they connected
     it successfully and are doing their thing.

After this, the attachment_update is just set volume to attaching in new flow, the end of attach flow is in attachment_complete, but it seems the notify is not updated when we do this change.

So, the time to send "attach.end" notify is unexpected.

[1] https://review.openstack.org/#/c/493262/3/cinder/volume/manager.py@4378

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/625856
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=283e1c2194b9fda1a6116df29b0644f449a69a76
Submitter: Zuul
Branch: master

commit 283e1c2194b9fda1a6116df29b0644f449a69a76
Author: Yikun Jiang <email address hidden>
Date: Tue Dec 18 17:21:29 2018 +0800

    Move 'attach.end' notify to attachment_complete

    Since microversion 3.44, we update `attachemnt_update` to return
    connector and make volume to 'attaching', and add a new api
    `attachment_complete` to change volume status to 'in-use', that means
    the end of attachment is changed to `attachment_complete`.

    But the 'attach.end' notify is still send in attachment_update, which
    is unexpected. So, in this patch we move 'attach.end' notify to
    `attachment_complete`.

    Change-Id: I86dad7afb52d2d253799b543f484e2d55f6e9e6d
    Closes-bug: #1808941

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.