Default policy file is not /etc/cinder/policy.yaml

Bug #1805550 reported by Brian Rosmaita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Brian Rosmaita

Bug Description

Observed this in master (stein), but it was introduced in Queens.

Change-Id Ie3ff068e61ea8e0e8fff78deb732e183e036a10c added the file etc/cinder/README-policy.generate.md that describes how to generate the sample policy file and also states:

"Cinder recognizes /etc/cinder/policy.yaml as the default policy file."

Unfortunately, cinder does not recognize this file unless it's explicitly configured in the [oslo_policy] section of /etc/cinder/cinder.conf .

The file cinder looks for by default is still /etc/cinder/policy.json .

I think the way to fix this is to change the code, not the documentation, since the idea is that it should be easy for an operator to copy the the generated policy file (which since Queens has been yaml) over to /etc/cinder and make any desired edits without also having to change the cinder.conf file.

Changed in cinder:
assignee: nobody → Brian Rosmaita (brian-rosmaita)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/620450

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/620450
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f6c11c2ceab035c65dedab6f514b6be28b1859bb
Submitter: Zuul
Branch: master

commit f6c11c2ceab035c65dedab6f514b6be28b1859bb
Author: Brian Rosmaita <email address hidden>
Date: Tue Nov 27 22:50:15 2018 -0500

    Correct default policy file

    Since Queens, the default policy file is policy.yaml, but the
    code is still looking for policy.json. This patch corrects the
    location and includes a release note.

    Change-Id: I997109d6bd1adbcbf72c056f78f1e01547d0fcbd
    Closes-bug: #1805550

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/621064

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/621296

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/rocky)

Reviewed: https://review.openstack.org/621064
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d07abe397c5bdfb45a82150fb7e1a9efaf21ce42
Submitter: Zuul
Branch: stable/rocky

commit d07abe397c5bdfb45a82150fb7e1a9efaf21ce42
Author: Brian Rosmaita <email address hidden>
Date: Tue Nov 27 22:50:15 2018 -0500

    Correct default policy file

    Since Queens, the default policy file is policy.yaml, but the
    code is still looking for policy.json. This patch corrects the
    location and includes a release note.

    Change-Id: I997109d6bd1adbcbf72c056f78f1e01547d0fcbd
    Closes-bug: #1805550
    (cherry picked from commit f6c11c2ceab035c65dedab6f514b6be28b1859bb)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/623340

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/queens)

Reviewed: https://review.openstack.org/623340
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=61e90d528d444fd98d6f34c4b0f81e4ac1e1f0d4
Submitter: Zuul
Branch: stable/queens

commit 61e90d528d444fd98d6f34c4b0f81e4ac1e1f0d4
Author: Brian Rosmaita <email address hidden>
Date: Tue Nov 27 22:50:15 2018 -0500

    Correct default policy file

    Since Queens, the default policy file is policy.yaml, but the
    code is still looking for policy.json. This patch corrects the
    location and includes a release note.

    Change-Id: I997109d6bd1adbcbf72c056f78f1e01547d0fcbd
    Closes-bug: #1805550
    (cherry picked from commit f6c11c2ceab035c65dedab6f514b6be28b1859bb)
    (cherry picked from commit d07abe397c5bdfb45a82150fb7e1a9efaf21ce42)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/621296
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d40b0b8b511e6472def2b976415715643b60b665
Submitter: Zuul
Branch: master

commit d40b0b8b511e6472def2b976415715643b60b665
Author: Brian Rosmaita <email address hidden>
Date: Fri Nov 30 16:28:47 2018 -0500

    Make policy config docs consistent

    The RST file introducing the sample policy file in the docs directory
    has gotten out of sync with etc/cinder/README-policy.generate.md

    Change-Id: Ic43c631bb7af0b4d888e539d4ca50e379f693b3c
    Partial-bug: #1805550

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.5

This issue was fixed in the openstack/cinder 12.0.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 13.0.3

This issue was fixed in the openstack/cinder 13.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 14.0.0.0rc1

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.