Non iSCSI attachments are being serialized

[Gorka Eguileor]

When the shared_targets concept was introduced it defaulted to True for any driver not reporting that capability, this meant that the attachment of all volumes would be serialized even if they have no concept of a "shared target".

This is caused because that feature was intended for iSCSI connections, but was applied to all connection types, introducing an unnecessary bottleneck on drivers like RBD or FC.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/613567

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/614215

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/614227

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/613567
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=043ada94eb35c6210367857714840188febf75a4
Submitter: Zuul
Branch: master

commit 043ada94eb35c6210367857714840188febf75a4
Author: Gorka Eguileor <email address hidden>
Date: Fri Oct 26 14:06:58 2018 +0200

    Fix non iSCSI attach serialization

    When the shared_targets concept was introduced it defaulted to True for
    any driver not reporting that capability. This meant that the
    attachment of all volumes would be serialized even if they have no
    concept of a "shared target".

    This is caused because that feature was intended for iSCSI connections,
    but was applied to all connection types, introducing an unnecessary
    bottleneck on drivers like RBD or FC.

    This patch makes sure to check that the storage_protocol is also iSCSI.

    Closes-Bug: #1800136
    Change-Id: I2805e8acf560cb941ddd3454477d89fe5a13d37f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614215
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=391b3f35d31658fa0e837b68c932b9e241160c6d
Submitter: Zuul
Branch: stable/rocky

commit 391b3f35d31658fa0e837b68c932b9e241160c6d
Author: Gorka Eguileor <email address hidden>
Date: Fri Oct 26 14:06:58 2018 +0200

    Fix non iSCSI attach serialization

    When the shared_targets concept was introduced it defaulted to True for
    any driver not reporting that capability. This meant that the
    attachment of all volumes would be serialized even if they have no
    concept of a "shared target".

    This is caused because that feature was intended for iSCSI connections,
    but was applied to all connection types, introducing an unnecessary
    bottleneck on drivers like RBD or FC.

    This patch makes sure to check that the storage_protocol is also iSCSI.

    Closes-Bug: #1800136
    Change-Id: I2805e8acf560cb941ddd3454477d89fe5a13d37f
    (cherry picked from commit 043ada94eb35c6210367857714840188febf75a4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614227
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=6b4b20f4476fb00ef137667c9865cf916b7293c3
Submitter: Zuul
Branch: stable/queens

commit 6b4b20f4476fb00ef137667c9865cf916b7293c3
Author: Gorka Eguileor <email address hidden>
Date: Fri Oct 26 14:06:58 2018 +0200

    Fix non iSCSI attach serialization

    When the shared_targets concept was introduced it defaulted to True for
    any driver not reporting that capability. This meant that the
    attachment of all volumes would be serialized even if they have no
    concept of a "shared target".

    This is caused because that feature was intended for iSCSI connections,
    but was applied to all connection types, introducing an unnecessary
    bottleneck on drivers like RBD or FC.

    This patch makes sure to check that the storage_protocol is also iSCSI.

    Closes-Bug: #1800136
    Change-Id: I2805e8acf560cb941ddd3454477d89fe5a13d37f
    (cherry picked from commit 043ada94eb35c6210367857714840188febf75a4)
    (cherry picked from commit 391b3f35d31658fa0e837b68c932b9e241160c6d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 13.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 12.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.