VNX unit tests are not Python 3.7 compatible

[Sean McGinnis]

When trying to run unit tests under Python 3.7, everything passes but the following two VNX tests:

cinder.tests.unit.volume.drivers.dell_emc.vnx.test_adapter.TestCommonAdapter.test_do_clone_cg
cinder.tests.unit.volume.drivers.dell_emc.vnx.test_adapter.TestCommonAdapter.test_do_create_cg_from_cgsnap

Both fail with the error "RuntimeError: generator raised StopIteration"

[Sean McGinnis (sean-mcginnis)]

May be an issue in taskflow: https://bugs.launchpad.net/taskflow/+bug/1780823

Will see if a fix there resolves this in Cinder or if any additional work is needed. May need at least a bump in the lower-constraints to ensure the version of taskflow is used that has whatever the fix will be for this.

[Corey Bryant (corey.bryant)]

The taskflow bug received some feedback from Ben Nemec [1] and he thinks this is not a taskflow isue.

"Looking a little closer at this, I'm not clear that this is a problem in Taskflow. The StopIteration is actually being raised from mock, which suggests to me that we have a mock with insufficient side_effects for the calls being made. I think this may be one of the subtle bugs that were previously getting masked by the silent handling of StopIteration."

[1] https://bugs.launchpad.net/taskflow/+bug/1780823/comments/6

[Corey Bryant (corey.bryant)]

Here's the related gerrit review to get py37 unit tests enabled: https://review.opendev.org/#/c/617840/

[Brian Rosmaita (brian-rosmaita)]

Here's the patch that was merged to get py37 in as a non-voting job:
https://review.opendev.org/#/c/655612/

[Yong Huang (yonghuang)]

I'm looking into the VNX failure cases.

[Yong Huang (yonghuang)]

Root caused, will submit fixes soon.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/659701

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/659701
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=18fbbd1afe2b9151fe521d200b280ae4a0ef6202
Submitter: Zuul
Branch: master

commit 18fbbd1afe2b9151fe521d200b280ae4a0ef6202
Author: Yong Huang <email address hidden>
Date: Fri May 17 10:03:46 2019 +0800

    [VNX] Fix test case issue

    Major changes:
    1. Fix mock file issue
    2. Fix cg test case issue

    Change-Id: Ia95936f3cea611f9fb7517d3b6849f511be2450b
    Closes-bug: #1795957

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/662669

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/662669
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=053c33cbfc2b4b72d9ca20f617e542452f98944f
Submitter: Zuul
Branch: stable/stein

commit 053c33cbfc2b4b72d9ca20f617e542452f98944f
Author: Yong Huang <email address hidden>
Date: Fri May 17 10:03:46 2019 +0800

    [VNX] Fix test case issue

    Major changes:
    1. Fix mock file issue
    2. Fix cg test case issue

    Change-Id: Ia95936f3cea611f9fb7517d3b6849f511be2450b
    Closes-bug: #1795957
    (cherry picked from commit 18fbbd1afe2b9151fe521d200b280ae4a0ef6202)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/665046

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665046
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4fd1cdcf62bf83b57d7685d19fa06daa522c9a98
Submitter: Zuul
Branch: stable/rocky

commit 4fd1cdcf62bf83b57d7685d19fa06daa522c9a98
Author: Yong Huang <email address hidden>
Date: Fri May 17 10:03:46 2019 +0800

    [VNX] Fix test case issue

    Major changes:
    1. Fix mock file issue
    2. Fix cg test case issue

    Change-Id: Ia95936f3cea611f9fb7517d3b6849f511be2450b
    Closes-bug: #1795957
    (cherry picked from commit 18fbbd1afe2b9151fe521d200b280ae4a0ef6202)
    (cherry picked from commit 053c33cbfc2b4b72d9ca20f617e542452f98944f)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/668353

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/668353
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f55d3a6f61b3be3df4597504d26385ddb72f6b6b
Submitter: Zuul
Branch: stable/queens

commit f55d3a6f61b3be3df4597504d26385ddb72f6b6b
Author: Yong Huang <email address hidden>
Date: Fri May 17 10:03:46 2019 +0800

    [VNX] Fix test case issue

    Major changes:
    1. Fix mock file issue
    2. Fix cg test case issue

    Change-Id: Ia95936f3cea611f9fb7517d3b6849f511be2450b
    Closes-bug: #1795957
    (cherry picked from commit 18fbbd1afe2b9151fe521d200b280ae4a0ef6202)
    (cherry picked from commit 053c33cbfc2b4b72d9ca20f617e542452f98944f)
    (cherry picked from commit 4fd1cdcf62bf83b57d7685d19fa06daa522c9a98)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 14.0.1 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.opendev.org/670428

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/670428
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9a1953a3bb78d85d6991b04ade68cb24e0c091b3
Submitter: Zuul
Branch: stable/pike

commit 9a1953a3bb78d85d6991b04ade68cb24e0c091b3
Author: Yong Huang <email address hidden>
Date: Fri May 17 10:03:46 2019 +0800

    [VNX] Fix test case issue

    Major changes:
    1. Fix mock file issue
    2. Fix cg test case issue

    Change-Id: Ia95936f3cea611f9fb7517d3b6849f511be2450b
    Closes-bug: #1795957
    (cherry picked from commit 18fbbd1afe2b9151fe521d200b280ae4a0ef6202)
    (cherry picked from commit 053c33cbfc2b4b72d9ca20f617e542452f98944f)
    (cherry picked from commit 4fd1cdcf62bf83b57d7685d19fa06daa522c9a98)
    (cherry picked from commit f55d3a6f61b3be3df4597504d26385ddb72f6b6b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 13.0.6 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 12.0.8 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 15.0.0.0rc1 release candidate.