Multiattach - multiattach is set to false after retype operation

[Helen Walsh]

While https://bugs.launchpad.net/cinder/+bug/1783790 addressed the manage use case it did not address the Retype use case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/604040

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rajat Dhasmana (<email address hidden>) on branch: master
Review: https://review.openstack.org/604040
Reason: Wrong approach here.
Correct patch:
https://review.openstack.org/605650

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/605650
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7f85be418669286392c833479dfdc7c2a33f86d1
Submitter: Zuul
Branch: master

commit 7f85be418669286392c833479dfdc7c2a33f86d1
Author: whoami-rajat <email address hidden>
Date: Thu Sep 27 16:45:34 2018 +0530

    Fix multiattach set to false after retype

    The return value of get_by_name_or_id in the volume_types module
    returns a dictionary.
    During the function call to _is_multiattach, the getattr() returns
    {}(default value) because a dictionary is passed instead of an object.
    After importing the cinder.objects.volume_type module,
    the current function call to get_by_name_or_id() returns an object
    hence getattr() will return the appropriate extra_specs instead of
    the default value({}).

    Closes-Bug: 1790840
    Change-Id: I869bc0c9b18887da1ea83f855d255557f0f3cba0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/613833

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/613833
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f4e3d58869f2bb0007d39b37f5634022368d0f63
Submitter: Zuul
Branch: stable/rocky

commit f4e3d58869f2bb0007d39b37f5634022368d0f63
Author: whoami-rajat <email address hidden>
Date: Thu Sep 27 16:45:34 2018 +0530

    Fix multiattach set to false after retype

    The return value of get_by_name_or_id in the volume_types module
    returns a dictionary.
    During the function call to _is_multiattach, the getattr() returns
    {}(default value) because a dictionary is passed instead of an object.
    After importing the cinder.objects.volume_type module,
    the current function call to get_by_name_or_id() returns an object
    hence getattr() will return the appropriate extra_specs instead of
    the default value({}).

    Closes-Bug: 1790840
    Change-Id: I869bc0c9b18887da1ea83f855d255557f0f3cba0
    (cherry picked from commit 7f85be418669286392c833479dfdc7c2a33f86d1)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 13.0.2 release.

[Artem Vasilyev (artem-v-vasilyev)]

I have encountered the same bug in Queens, but only Rocky was patched. Is it possible to backport it to the Queens release?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/641068

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/641068
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=2d8f2dc117ea80a808baf4209dbe01f2c7393d9e
Submitter: Zuul
Branch: stable/queens

commit 2d8f2dc117ea80a808baf4209dbe01f2c7393d9e
Author: whoami-rajat <email address hidden>
Date: Thu Sep 27 16:45:34 2018 +0530

    Fix multiattach set to false after retype

    The return value of get_by_name_or_id in the volume_types module
    returns a dictionary.
    During the function call to _is_multiattach, the getattr() returns
    {}(default value) because a dictionary is passed instead of an object.
    After importing the cinder.objects.volume_type module,
    the current function call to get_by_name_or_id() returns an object
    hence getattr() will return the appropriate extra_specs instead of
    the default value({}).

    Closes-Bug: 1790840
    Change-Id: I869bc0c9b18887da1ea83f855d255557f0f3cba0
    (cherry picked from commit 7f85be418669286392c833479dfdc7c2a33f86d1)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 12.0.6 release.