VMware: revert-to-snapshot fails with TypeError

[Vipin Balachandran]

Aug 30 13:35:22 destiny cinder-volume[109185]: ERROR cinder.volume.manager [req-44fe527b-9ec1-47fb-8cdb-5de4f983c83e req-906a902e-0692-4ec6-aa89-5d4ca2f90a6e demo None] Volume 0a9b8caf-5b91-4105-98b9-d3c5e72485e7 revert to snapshot 4b941c90-80ba-442a-86ca-b287106b030e failed with get_backing() takes exactly 3 arguments (2 given).: TypeError: get_backing() takes exactly 3 arguments (2 given)
Aug 30 13:35:22 destiny cinder-volume[109185]: ERROR cinder.volume.manager Traceback (most recent call last):
Aug 30 13:35:22 destiny cinder-volume[109185]: ERROR cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 982, in revert_to_snapshot
Aug 30 13:35:22 destiny cinder-volume[109185]: ERROR cinder.volume.manager self._revert_to_snapshot(context, volume, snapshot)
Aug 30 13:35:22 destiny cinder-volume[109185]: ERROR cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 930, in _revert_to_snapshot
Aug 30 13:35:22 destiny cinder-volume[109185]: ERROR cinder.volume.manager self.driver.revert_to_snapshot(context, volume, snapshot)
Aug 30 13:35:22 destiny cinder-volume[109185]: ERROR cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/vmware/vmdk.py", line 2221, in revert_to_snapshot
Aug 30 13:35:22 destiny cinder-volume[109185]: ERROR cinder.volume.manager backing = self.volumeops.get_backing(volume.name)
Aug 30 13:35:22 destiny cinder-volume[109185]: ERROR cinder.volume.manager TypeError: get_backing() takes exactly 3 arguments (2 given)
Aug 30 13:35:22 destiny cinder-volume[109185]: ERROR cinder.volume.manager

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/598361

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/598361
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=258beef2649d79c24ddafaf2064e94557c316bde
Submitter: Zuul
Branch: master

commit 258beef2649d79c24ddafaf2064e94557c316bde
Author: Vipin Balachandran <email address hidden>
Date: Thu Aug 30 14:38:16 2018 -0700

    VMware: Fix revert-to-snapshot

    Commit 46b8da35d79121df34ec9befd353c8c428be846b modified
    the method we use to query the backend volumes. But,
    revert-to-snapshot implementation which was in-progress
    when the above commit was merged missed that change.
    Fixing it by updating the query method call in
    revert_to_snapshot.

    Change-Id: I34cbd4420b43f52cd8d23833658f6386cb3e6437
    Closes-bug: #1790008

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/639749

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/639749
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5c1f6c0535aa73b482fc927be47c51d512f814ce
Submitter: Zuul
Branch: stable/rocky

commit 5c1f6c0535aa73b482fc927be47c51d512f814ce
Author: Vipin Balachandran <email address hidden>
Date: Thu Aug 30 14:38:16 2018 -0700

    VMware: Fix revert-to-snapshot

    Commit 46b8da35d79121df34ec9befd353c8c428be846b modified
    the method we use to query the backend volumes. But,
    revert-to-snapshot implementation which was in-progress
    when the above commit was merged missed that change.
    Fixing it by updating the query method call in
    revert_to_snapshot.

    Change-Id: I34cbd4420b43f52cd8d23833658f6386cb3e6437
    Closes-bug: #1790008
    (cherry picked from commit 258beef2649d79c24ddafaf2064e94557c316bde)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 13.0.4 release.