Incorrect move to os.mkdir in Nexenta NFS and Quobyte Drivers

Bug #1780750 reported by Silvan Kaiser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Silvan Kaiser

Bug Description

The recent Cinder change [1] moved shell mkdir commands to pythons os.mkdir commands. However as the shell commands were running with the '-p' option os.makedirs is required instead. Using os.mkdir results in failures as shown e.g. in the changes Quobyte CI run as the required mount point is not created correctly.

[1] https://review.openstack.org/#/c/580629/
[2] http://78.46.57.153:8081/refs-changes-29-580629-1/console.log.out

Silvan Kaiser (2-silvan)
Changed in cinder:
assignee: nobody → Silvan Kaiser (2-silvan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/580972

Changed in cinder:
status: New → In Progress
Silvan Kaiser (2-silvan)
summary: - Incorrect move to os.mkdir in Quobyte Driver
+ Incorrect move to os.mkdir in Nexenta NFS and Quobyte Drivers
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/580972
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=8f1cd6983d89debb4a835f022004ae2dee3a1ee3
Submitter: Zuul
Branch: master

commit 8f1cd6983d89debb4a835f022004ae2dee3a1ee3
Author: Silvan Kaiser <email address hidden>
Date: Mon Jul 9 11:05:55 2018 +0200

    Use ensure_tree instead of mkdir when creating paths

    Use fileutils.ensure_tree instead of shell based mkdir commands when
    creating mount points.

    Closes-Bug: #1780750

    Change-Id: I5a4155529e3c6dbc7f4d0e43561658bbba8a715d

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 13.0.0.0b3

This issue was fixed in the openstack/cinder 13.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.