Quota Update API does not Require a Quota Value to Update

[Dustin Schoenbrun]

With both the CLI and APIs for updating quotas of at least Cinder and Manila it is possible to create a request with a body that does not change any quota. This is partially because the options to these APIs are all optional and the API layer (nor the CLI) does not do any validation of the body of the request to ensure there is actually something to do.

Versions:
Appears to impact Master as well as at least Queens.

Steps to Reproduce:
1) Set up Cinder and/or Manila.
2) Using the "manila|cinder quota-update" command, attempt to update a quota while supplying only a project to update.
3) Observe that without specifying a quota to update the request was still successful.

Observed Results:
The empty quota update request completes without error.

Expected Results:
The empty quota request should either generate an error saying that there was nothing given to update or a warning stating the same.

[Tom Barron (tpb)]

We may be able to address issues of this sort via the proposed json schema validation - initial patch at https://review.openstack.org/#/c/563429/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 5.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/798206

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/798206
Committed: https://opendev.org/openstack/manila/commit/c07f2d8ba8c97294858af1fb6388135de17b509d
Submitter: "Zuul (22348)"
Branch: master

commit c07f2d8ba8c97294858af1fb6388135de17b509d
Author: Felipe Rodrigues <email address hidden>
Date: Wed Apr 1 19:50:58 2020 +0000

    Fix quota-set no required parameters on update

    Fixes an issue on manila api while trying to update a quota
    without specifying a value.

    Change-Id: I660a0f703edf8bfd91f78ed1b0c258828a1d12a2
    Closes-Bug: #1778975

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 14.0.0.0rc1 release candidate.