Cinder Volume is incorrectly logging request id

Bug #1773924 reported by yuanyue
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
yuanyue

Bug Description

Similar to https://bugs.launchpad.net/cinder/+bug/1743461, currently all log entries will have the request ID of the latest request that was received in the cinder-volume service.

Example:
During and after volume creation, the request id related to periodic tasks is changed:

2018-05-29 03:52:17.790 2561 DEBUG cinder.volume.manager [req-daccffb6-0e26-4923-9433-cdfe3ab716a8 9de813eb53ba4ac982a37df462783d5d 3ce4f026aed1411baa6e8013b13f9257 - - -] Task 'cinder.volume.flows.manager.create_volume.ExtractVolumeRefTask;volume:create' (3290c197-bcc9-4d8e-8bae-fdbb69fc3258) transitioned into state 'RUNNING' from state 'PENDING' _task_receiver /usr/lib/python2.7/site-packages/taskflow/listeners/logging.py:194

...

2018-05-29 03:52:18.868 2561 INFO cinder.volume.manager [req-daccffb6-0e26-4923-9433-cdfe3ab716a8 9de813eb53ba4ac982a37df462783d5d 3ce4f026aed1411baa6e8013b13f9257 - - -] Created volume successfully.
2018-05-29 03:53:12.079 2561 DEBUG oslo_service.periodic_task [req-daccffb6-0e26-4923-9433-cdfe3ab716a8 9de813eb53ba4ac982a37df462783d5d 3ce4f026aed1411baa6e8013b13f9257 - - -] Running periodic task VolumeManager._publish_service_capabilities run_periodic_tasks /usr/lib/python2.7/site-packages/oslo_service/periodic_task.py:215
2018-05-29 03:53:12.079 2561 DEBUG cinder.manager [req-daccffb6-0e26-4923-9433-cdfe3ab716a8 9de813eb53ba4ac982a37df462783d5d 3ce4f026aed1411baa6e8013b13f9257 - - -] Notifying Schedulers of capabilities ... _publish_service_capabilities /usr/lib/python2.7/site-packages/cinder/manager.py:189

Revision history for this message
yuanyue (yyuanyuee) wrote :

cinder version:
python-cinder-12.0.0-1.el7.noarch
openstack-cinder-12.0.0-1.el7.noarch

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/570870

Changed in cinder:
assignee: nobody → yuanyue (yyuanyuee)
status: New → In Progress
Changed in cinder:
assignee: yuanyue (yyuanyuee) → Eric Harney (eharney)
Eric Harney (eharney)
Changed in cinder:
assignee: Eric Harney (eharney) → yuanyue (yyuanyuee)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/570870
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=219961bff62e2b507737ff11a82e18686bdd2c0a
Submitter: Zuul
Branch: master

commit 219961bff62e2b507737ff11a82e18686bdd2c0a
Author: yuanyue <yyuanyuee@163.com>
Date: Tue May 29 04:57:32 2018 -0400

    Fix cinder-volume uses latest req-id for all log calls

    Currently all log entries will have the request ID of the
    latest request that was received in the cinder-volume service.

    To fix this we just move the monkey patching to the top in the
    imports.

    Change-Id: Ic1ad7a38cf21256d9446fd2c0270610b4cfe75c5
    Closes-Bug: #1773924

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 13.0.0.0b3

This issue was fixed in the openstack/cinder 13.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/593046

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/queens)

Reviewed: https://review.openstack.org/593046
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e6d1fd153320fe4875d2d8e2a6aa21779c3d0977
Submitter: Zuul
Branch: stable/queens

commit e6d1fd153320fe4875d2d8e2a6aa21779c3d0977
Author: yuanyue <yyuanyuee@163.com>
Date: Tue May 29 04:57:32 2018 -0400

    Fix cinder-volume uses latest req-id for all log calls

    Currently all log entries will have the request ID of the
    latest request that was received in the cinder-volume service.

    To fix this we just move the monkey patching to the top in the
    imports.

    Change-Id: Ic1ad7a38cf21256d9446fd2c0270610b4cfe75c5
    Closes-Bug: #1773924
    (cherry picked from commit 219961bff62e2b507737ff11a82e18686bdd2c0a)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.4

This issue was fixed in the openstack/cinder 12.0.4 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.