cinder-volume unnecessarily refreshes the storage stats

[Gorka Eguileor]

Refreshing the stats is a costly operation for most drivers, but we are
still calling it on 3 manager actions that don't require it:

- delete_volume
- retype
- delete_group

This is probably due to an unfortunately naming of the method, because
`publish_service_capabilities` seem to indicate that we'll only be
publishing this information, but the method is also refreshing the stats
from the driver.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/546733

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/546733
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=458840ddb12164c27054413bb7a7ffcd168b614e
Submitter: Zuul
Branch: master

commit 458840ddb12164c27054413bb7a7ffcd168b614e
Author: Gorka Eguileor <email address hidden>
Date: Wed Feb 21 19:16:03 2018 +0100

    Stop unnecessarily querying storage for stats

    Refreshing the stats is a costly operation for most drivers, but we are
    still calling it on 3 manager actions that don't require it:

    - delete_volume
    - retype
    - delete_group

    This is probably due to an unfortunately naming of the method, because
    `publish_service_capabilities` seem to indicate that we'll only be
    publishing this information, but the method is also refreshing the stats
    from the driver.

    This patch removes all unnecessary calls to
    `publish_service_capabilities`.

    Change-Id: If2ae4abfa0e961607591239dabce8e539994a7da
    Closes-Bug: #1750885

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 13.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/593193

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/593193
Reason: This was found to have issues:

https://bugs.launchpad.net/cinder/+bug/1741275