SMBFS: provisioning type not honored

Bug #1745602 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Lucian Petrut

Bug Description

At the moment, the SMBFS driver does not honor the configured provisioning type.

The issue is that we're checking CONF.backend_defaults instead of the driver configuration object, for which reason if the option is defined in the according backend config group, it will be ignored.

So, the following will work:

[backend_defaults]
nas_volume_provisioning_type = thick

While the following will not:

[DEFAULT]
enabled_backends = winsmb

[winsmb]
volume_driver = cinder.volume.drivers.windows.smbfs.WindowsSmbfsDriver
nas_volume_provisioning_type = thick

Changed in cinder:
assignee: nobody → Lucian Petrut (petrutlucian94)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/538232

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/538232
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=06698bf0128f5b1f6865b7732b9ebbf5bb2818d1
Submitter: Zuul
Branch: master

commit 06698bf0128f5b1f6865b7732b9ebbf5bb2818d1
Author: Lucian Petrut <email address hidden>
Date: Fri Jan 26 14:05:40 2018 +0200

    [Trivial] SMBFS: fix provisioning type usage

    At the moment, the SMBFS driver does not honor the configured
    provisioning type.

    The issue is that we're checking CONF.backend_defaults instead
    of the driver configuration object, for which reason if the option
    is defined in the according backend config group, it will be ignored.

    This change fixes this issue, updating the config option checks.

    Change-Id: Ieb9e9edb1bc46d8b6ca31480d963f9dc9c2331de
    Closes-Bug: #1745602

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.0.0rc1

This issue was fixed in the openstack/cinder 12.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.