Context's request-id not found in response of volume actions.

Bug #1743404 reported by Ibad Khan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Ibad Khan

Bug Description

Majority of volume actions lack request-id whenever we have no data in response. Noticed that the actions return native webob.Response object because of which cinder's wsgi layer doesn't add context's response-id in the header.

wsgi block that decides whether to append response-id in header:
https://github.com/openstack/cinder/blob/master/cinder/api/openstack/wsgi.py#L906-L915

Changed in cinder:
status: New → Confirmed
importance: Undecided → Low
Ibad Khan (ik-ibadkhan)
Changed in cinder:
assignee: nobody → Ibad Khan (ik-ibadkhan)
status: Confirmed → New
Ibad Khan (ik-ibadkhan)
summary: - Context response-id not found in response of volume actions.
+ Context's request-id not found in response of volume actions.
description: updated
Ibad Khan (ik-ibadkhan)
Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/534363

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/534363
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=745e84d5c4d3708ad2e71f49e4bcdb6f9fd30b54
Submitter: Zuul
Branch: master

commit 745e84d5c4d3708ad2e71f49e4bcdb6f9fd30b54
Author: Ibadulla Khan <email address hidden>
Date: Tue Jan 16 12:51:10 2018 +0530

    Fix: request-id missing in volume action's response header.

    Several volume actions use webob.Response object to
    return HTTP codes and cinder's wsgi layer doesn't append
    request-id if the actions return webob.Response object.

    If we intend to return certain HTTP code, we should use
    wsgi.response decorator and let cinder's wsgi layer create
    response object of it's own.

    Change-Id: Ibd6f60301e73022fecae4286e68d152bab73a40e
    Closes-Bug: 1743404

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.0.0rc1

This issue was fixed in the openstack/cinder 12.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.