Cinder tempest plugin test should not use unstable interface

Bug #1734821 reported by Ghanshyam Mann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Ghanshyam Mann

Bug Description

All the cinder tempest plugin tests are inherited from tempest/api/volume/base.py which is not stable class and can be changed anytime by tempest.

One recent case where some changes in base class on tempest side could have break the cinder tests- http://logs.openstack.org/07/522707/3/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/a92cd60/logs/testr_results.html.gz

Instead of tempest/api/volume/base.py, tests should use tempest/test.py which is stable interface for plugins.

Changed in cinder:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder-tempest-plugin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/533118

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Ghanshyam Mann (<email address hidden>) on branch: master
Review: https://review.openstack.org/523354

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder-tempest-plugin (master)

Reviewed: https://review.openstack.org/533118
Committed: https://git.openstack.org/cgit/openstack/cinder-tempest-plugin/commit/?id=dae4b6df5f354355cf56eee2547314b2282670f4
Submitter: Zuul
Branch: master

commit dae4b6df5f354355cf56eee2547314b2282670f4
Author: ghanshyam <email address hidden>
Date: Fri Jan 12 07:49:15 2018 +0000

    Cinder Tempest plugin tests: Switch to stable interface

    All the cinder tempest plugin tests are inherited from tempest/api/volume/base.py
    which is not stable class and can be changed anytime by tempest.

    One recent case where some changes in base class on tempest side could
    have break the cinder tests-
     http://logs.openstack.org/07/522707/3/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/a92cd60/logs/testr_results.html.gz

    This commit switch cinder tests to use test.py which is stable interface
    for plugin and create a base class with commonly used function & variable.

    Change-Id: I0edda1fa23aed0b3d25691d5f4440a7234decc9a
    Closes-Bug: #1734821

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/557385

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/pike)

Reviewed: https://review.openstack.org/557385
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=b52b4533c802e5143588d37cf2e854a31f5fbc13
Submitter: Zuul
Branch: stable/pike

commit b52b4533c802e5143588d37cf2e854a31f5fbc13
Author: ghanshyam <email address hidden>
Date: Fri Jan 12 07:49:15 2018 +0000

    Cinder Tempest plugin tests: Switch to stable interface

    All the cinder tempest plugin tests are inherited from tempest/api/volume/base.py
    which is not stable class and can be changed anytime by tempest.

    One recent case where some changes in base class on tempest side could
    have break the cinder tests-
     http://logs.openstack.org/07/522707/3/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/a92cd60/logs/testr_results.html.gz

    This commit switch cinder tests to use test.py which is stable interface
    for plugin and create a base class with commonly used function & variable.

    Change-Id: I0edda1fa23aed0b3d25691d5f4440a7234decc9a
    Closes-Bug: #1734821
    (cherry picked from commit dae4b6df5f354355cf56eee2547314b2282670f4)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/563209

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/ocata)

Reviewed: https://review.openstack.org/563209
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9ca58419dfa565f8cd26080e864edcb47a2bb701
Submitter: Zuul
Branch: stable/ocata

commit 9ca58419dfa565f8cd26080e864edcb47a2bb701
Author: ghanshyam <email address hidden>
Date: Fri Jan 12 07:49:15 2018 +0000

    Cinder Tempest plugin tests: Switch to stable interface

    All the cinder tempest plugin tests are inherited from tempest/api/volume/base.py
    which is not stable class and can be changed anytime by tempest.

    One recent case where some changes in base class on tempest side could
    have break the cinder tests-
     http://logs.openstack.org/07/522707/3/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/a92cd60/logs/testr_results.html.gz

    This commit switch cinder tests to use test.py which is stable interface
    for plugin and create a base class with commonly used function & variable.

    Closes-Bug: #1734821

     Conflicts:
     cinder/tests/tempest/api/volume/test_volume_backup.py
     cinder/tests/tempest/api/volume/test_volume_revert.py

    NOTE(melwitt): The conflicts are because test_volume_revert.py does not
    exist in Ocata and test_volume_backup.py has a snapshot_backup_opt
    config option that does not exist in Pike.

    Change-Id: I0edda1fa23aed0b3d25691d5f4440a7234decc9a
    (cherry picked from commit dae4b6df5f354355cf56eee2547314b2282670f4)
    (cherry picked from commit b52b4533c802e5143588d37cf2e854a31f5fbc13)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.7

This issue was fixed in the openstack/cinder 10.0.7 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 11.1.1

This issue was fixed in the openstack/cinder 11.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.