Policy documentation wrong for os-show_image_metadata endpoint

Bug #1733632 reported by Felipe Monteiro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Felipe Monteiro

Bug Description

The policy documentation for os-show_image_metadata endpoint is inconsistent with the implementation.

In policy documentation, the endpoint is listed as enforcing "volume_extension:volume_image_metadata": https://github.com/openstack/cinder/blob/9fbf236dc17d67404e2ce9ced517182716d72e6f/cinder/policies/volume_metadata.py#L102

But in the code it is clear that no policy enforcement is performed: https://github.com/openstack/cinder/blob/0cf910d4345c000e8c306b1cb2b2dd291975cf71/cinder/api/contrib/volume_image_metadata.py#L123

Felipe Monteiro (fm577c)
Changed in cinder:
assignee: nobody → Felipe Monteiro (fm577c)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/521915

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/521915
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=52576bbbc89af0842b2c7bda2bc4b0d6214bccbb
Submitter: Zuul
Branch: master

commit 52576bbbc89af0842b2c7bda2bc4b0d6214bccbb
Author: Felipe Monteiro <email address hidden>
Date: Tue Nov 21 16:02:54 2017 +0000

    Fix policy documentation for os-show_image_metadata endpoint

    The policy documentation for os-show_image_metadata endpoint
    is inconsistent with the implementation.

    In policy documentation, the endpoint is listed as enforcing
    "volume_extension:volume_image_metadata": [0]

    But in the code it is clear that no policy enforcement is performed: [1]

    This PS removes the os-show_image_metadata entry from the policy
    documentation for consistency.

    [0] https://github.com/openstack/cinder/blob/9fbf236dc17d67404e2ce9ced517182716d72e6f/cinder/policies/volume_metadata.py#L102
    [1] https://github.com/openstack/cinder/blob/0cf910d4345c000e8c306b1cb2b2dd291975cf71/cinder/api/contrib/volume_image_metadata.py#L123

    Change-Id: Icfde885384d174dbf9b211faca3f31be0b41f232
    Closes-Bug: #1733632

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.0.0b3

This issue was fixed in the openstack/cinder 12.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.