Netapp cDot drivers allow double manage

[Erlon R. Cruz]

In NetApp cDot controllers, if the admin passes the ID of a volume
that is already managed by Cinder, the controller will rename the
volume file and Cinder will still count on that volume. This will
cause the volume to fall in an error state in the next operation
performed on it.

Steps to reproduce:
1 - Create a volume v1 and get its file name (volume-v1['id'])
2 - Manage the same file using the manage API
    $ cinder manage host@backend#pool1 volume-v1['id']
3 - Do any operation on v1 (delete, extend, etc)
4 - Operation fails and v1 goes to an error state

[Naresh Kumar Gunjalli (nareshkumarg)]

I tried to reproduce this issue but the issue has been fixed.

I created a iscsi volume "double1".
This volume double1 is provisioned on "iscsi_flexvol2" flexvol of ontap..

root@scspa0603147001:~# cinder list
+--------------------------------------+-----------+---------+------+-------------+----------+-------------+
| ID | Status | Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+-----------+---------+------+-------------+----------+-------------+
| f77afdf8-6225-4f08-8f9f-c5eee765e223 | available | double1 | 1 | ontap-iscsi | false | |
+--------------------------------------+-----------+---------+------+-------------+----------+-------------+

fas3250-2n-rtp-4::> lun show -vserver openstack_iscsi
Vserver Path State Mapped Type Size
--------- ------------------------------- ------- -------- -------- --------
openstack_iscsi
          /vol/iscsi_flexvol2/volume-f77afdf8-6225-4f08-8f9f-c5eee765e223
                                          online unmapped linux 1GB

List of cinder pools in my system..
root@scspa0603147001:~# cinder get-pools
+----------+-----------------------------------------+
| Property | Value |
+----------+-----------------------------------------+
| name | scspa0603147001@lvmdriver-1#lvmdriver-1 |
+----------+-----------------------------------------+
+----------+--------------------------------------------+
| Property | Value |
+----------+--------------------------------------------+
| name | scspa0603147001@ontap-iscsi#iscsi_flexvol2 |
+----------+--------------------------------------------+
+----------+-------------------------------------------+
| Property | Value |
+----------+-------------------------------------------+
| name | scspa0603147001@ontap-iscsi#iscsi_flexvol |
+----------+-------------------------------------------+

I tried to double manage the above created cinder volume but it fails with following error,
root@scspa0603147001:~# cinder manage scspa0603147001@ontap-iscsi#iscsi_flexvol2 volume-f77afdf8-6225-4f08-8f9f-c5eee765e223
ERROR: Unable to manage existing volume. The volume is already managed (HTTP 400) (Request-ID: req-3b9838b6-811f-45ec-ab35-ecf5e0e4de6c)

This issue is fixed in the Upstream.. Refer
https://github.com/openstack/cinder/commit/4f649809a4a51a5ddbce290ca0dcb3f1566f044b#diff-33011bbeb0dd51161827701307e6d033
https://github.com/openstack/cinder/commit/61962d2522fb778d0bc2e0f511a541579e7b2f89#diff-33011bbeb0dd51161827701307e6d033

I have tested this issue in Rocky and Stein releases and no issues of double manage allowed in these versions..