Cinder

vg_thin_pool_size should be float type

Bug #1715041 reported by wanghongxu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Wishlist
wanghongxu
os-brick
Fix Released
Undecided
wanghongxu

Bug Description

in cinder/brick/local_dev/lvm.py:416
                if not lv['size'][-1].isdigit():
                    lvsize = lvsize[:-1]
                if lv['name'] == self.vg_thin_pool:
                    self.vg_thin_pool_size = lvsize
lvsize is str not a float

wanghongxu (wang19930902)
Changed in cinder:
assignee: nobody → wanghongxu (wang19930902)
OpenStack Infra (hudson-openstack)
Changed in cinder:
status: New → In Progress
Eric Harney (eharney)
Changed in cinder:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/500663
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9a386cee127519ce70a0ef494cbbeaeb7f52c5e7
Submitter: Zuul
Branch: master

commit 9a386cee127519ce70a0ef494cbbeaeb7f52c5e7
Author: wanghongxu <email address hidden>
Date: Tue Sep 5 11:23:48 2017 +0800

    set vg_thin_pool_size to float type

    lvsize is type of str, we need a float type.

    Closes-Bug: #1715041
    Change-Id: Ic9720c649ccb1fbcf2f319c0cc422c54f0925aac

Changed in cinder:
status: In Progress → Fix Released
wanghongxu (wang19930902)
Changed in os-brick:
assignee: nobody → wanghongxu (wang19930902)
wanghongxu (wang19930902)
Changed in os-brick:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.0.0b2

This issue was fixed in the openstack/cinder 12.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)

Reviewed: https://review.openstack.org/523273
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=aa8cccd1bc1e9475e4b6a0f1fa42c14584da219a
Submitter: Zuul
Branch: master

commit aa8cccd1bc1e9475e4b6a0f1fa42c14584da219a
Author: wanghongxu <email address hidden>
Date: Tue Nov 28 09:58:24 2017 +0800

    set vg_thin_pool_size to float type

    lvsize is type of str, we need a float type.

    Change-Id: I2ade0ae1f788f75078b65f701ee051d0f13adbb3
    Closes-Bug: #1715041

Changed in os-brick:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 2.2.0

This issue was fixed in the openstack/os-brick 2.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/647743

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (stable/pike)

Reviewed: https://review.openstack.org/647743
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=bd4981e78dd2109458e21b8957d318e8da4d85e4
Submitter: Zuul
Branch: stable/pike

commit bd4981e78dd2109458e21b8957d318e8da4d85e4
Author: wanghongxu <email address hidden>
Date: Tue Nov 28 09:58:24 2017 +0800

    set vg_thin_pool_size to float type

    lvsize is type of str, we need a float type.

    Change-Id: I2ade0ae1f788f75078b65f701ee051d0f13adbb3
    Closes-Bug: #1715041
    (cherry picked from commit aa8cccd1bc1e9475e4b6a0f1fa42c14584da219a)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 1.15.9

This issue was fixed in the openstack/os-brick 1.15.9 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.