HPE 3PAR: Retype from thin to full provisioning Fails on Replication setup

[Shashi]

Observation -
Volume retype from ‘replication_enabled’ with full provisioning to ‘replication_enabled’ with thin provisioning fails.

Steps To reproduce -

1. Create devstack.
2. Configure 3PAR with replication with this devstack
3. Create 2 volume-types, volumeType-1 and VolumeType-2
4. Set below extra specs on these Volume types
a. VolumeType-1: volume_backend_name,replication_enabled=’<is> true’,hpe3par:provisioning=full
b. VolumeType-1: volume_backend_name,replication_enabled=’<is> true’,hpe3par:provisioning=thin
5. Create volume using VolumeType-1
6. Retype this volume to VolumeType-2
7. Verify the provisioning on the retyped volume.

Expected Result - Retyped volume should show provisioning as thin

Actual Result - Retype fails.

Note: - Issue is reproducible for retyping from thin to full as well.

Attaching relevant logs.

Below is the detailed output -

stack@cld6b16:~$ cinder extra-specs-list
+--------------------------------------+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| ID | Name | extra_specs |
+--------------------------------------+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| 01072a3a-0aaf-4856-9c54-570bb483bc95 | lefthand | {'hpelh:provisioning': 'full', 'hpelh:ao': 'false', 'volume_backend_name': 'lefthand'} |
| 0f50088b-797f-4dc1-9176-e7f1a226145d | 3pariscsirep1 | {'hpe3par:provisioning': 'full', 'replication_enabled': '<is> True', 'volume_backend_name': '3pariscsirep1'} |
| 189b165d-d929-49f6-a61c-4c97af87df97 | 3pariscsi | {'hpe3par:provisioning': 'dedup', 'volume_backend_name': '3pariscsi', 'hpe3par:compression': 'true'} |
| 1f2333e4-03db-43db-9367-12f204f66d3b | 3pariscsirep | {'replication_enabled': '<is> True', 'volume_backend_name': '3pariscsirep1'} |
| 4909cf60-9c73-4ddd-b532-f9ddae0a25c8 | VIVEK | {'volume_backend_name': 'VIVEK'} |
| ac6ebe23-1a39-471d-8130-b33146b6db8e | lefthand3 | {'hpelh:ao': 'false', 'volume_backend_name': 'lefthand'} |
| b33b9f0c-922e-4f16-b092-53b035a554d7 | lefthand2 | {'volume_backend_name': 'lefthand'} |
| b5c05556-f7bd-4a72-a8f9-9200676284dc | 3pariscsi_vvk | {'hpe3par:provisioning': 'full', 'replication_enabled': '<is> True', 'volume_backend_name': '3pariscsirep', 'replication:mode': 'sync', 'hpe3par:compression': 'true'} |
| e26aee11-216a-406a-8cfa-01370d4fbcb1 | lvmdriver-1 | {'volume_backend_name': 'lvmdriver-1'} |
+--------------------------------------+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
stack@cld6b16:~$

stack@cld6b16:~$ cinder list
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
| ID | Status | Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
| 161ddcc3-b3cc-401f-bb2e-cdccf80638a5 | available | 6628-Scenario-1 | 10 | 3pariscsirep1 | false | |
| b452bed5-14c7-4efd-bda7-43e5e256b6eb | error | vvk_vol | 2 | VIVEK | false | |
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
stack@cld6b16:~$
stack@cld6b16:~$ cinder delete 6628-Scenario-1
Request to delete volume 6628-Scenario-1 has been accepted.
stack@cld6b16:~$
stack@cld6b16:~$
stack@cld6b16:~$ cinder list
+--------------------------------------+-----------+---------+------+-------------+----------+-------------+
| ID | Status | Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+-----------+---------+------+-------------+----------+-------------+
| affb42e3-7326-4c1d-a884-b7a233d9e5f5 | attaching | vvk_vol | 2 | VIVEK | false | |
+--------------------------------------+-----------+---------+------+-------------+----------+-------------+
stack@cld6b16:~$

NO VVs on Primary -

Retype from FullToThin

Existing Volume Types
stack@cld6b16:~$ cinder extra-specs-list
+--------------------------------------+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| ID | Name | extra_specs |
+--------------------------------------+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| 01072a3a-0aaf-4856-9c54-570bb483bc95 | lefthand | {'hpelh:provisioning': 'full', 'hpelh:ao': 'false', 'volume_backend_name': 'lefthand'} |
| 0f50088b-797f-4dc1-9176-e7f1a226145d | 3pariscsirep1 | {'hpe3par:provisioning': 'full', 'replication_enabled': '<is> True', 'volume_backend_name': '3pariscsirep1'} |
| 189b165d-d929-49f6-a61c-4c97af87df97 | 3pariscsi | {'hpe3par:provisioning': 'dedup', 'volume_backend_name': '3pariscsi', 'hpe3par:compression': 'true'} |
| 1f2333e4-03db-43db-9367-12f204f66d3b | 3pariscsirep | {'replication_enabled': '<is> True', 'volume_backend_name': '3pariscsirep1'} |
| 4909cf60-9c73-4ddd-b532-f9ddae0a25c8 | VIVEK | {'volume_backend_name': 'VIVEK'} |
| ac6ebe23-1a39-471d-8130-b33146b6db8e | lefthand3 | {'hpelh:ao': 'false', 'volume_backend_name': 'lefthand'} |
| b33b9f0c-922e-4f16-b092-53b035a554d7 | lefthand2 | {'volume_backend_name': 'lefthand'} |
| b5c05556-f7bd-4a72-a8f9-9200676284dc | 3pariscsi_vvk | {'hpe3par:provisioning': 'full', 'replication_enabled': '<is> True', 'volume_backend_name': '3pariscsirep', 'replication:mode': 'sync', 'hpe3par:compression': 'true'} |
| e26aee11-216a-406a-8cfa-01370d4fbcb1 | lvmdriver-1 | {'volume_backend_name': 'lvmdriver-1'} |
+--------------------------------------+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
stack@cld6b16:~$
Create Volume with 3pariscsirep1 volume type

stack@cld6b16:~$ cinder create --name 6628-Scenario-3 --volume-type 3pariscsirep1 12 - This has full provisioning
+--------------------------------+--------------------------------------+
| Property | Value |
+--------------------------------+--------------------------------------+
| attachments | [] |
| availability_zone | nova |
| bootable | false |
| consistencygroup_id | None |
| created_at | 2017-08-21T11:35:28.000000 |
| description | None |
| encrypted | False |
| id | 7e52f5d5-1a73-4f88-a212-31ed0c2dd279 |
| metadata | {} |
| migration_status | None |
| multiattach | False |
| name | 6628-Scenario-3 |
| os-vol-host-attr:host | None |
| os-vol-mig-status-attr:migstat | None |
| os-vol-mig-status-attr:name_id | None |
| os-vol-tenant-attr:tenant_id | 3e7592304d144cd9ba93d8b21f0d67b6 |
| replication_status | None |
| size | 12 |
| snapshot_id | None |
| source_volid | None |
| status | creating |
| updated_at | None |
| user_id | 0911f154b383405495c96ebcf11b5f60 |
| volume_type | 3pariscsirep1 |
+--------------------------------+--------------------------------------+
stack@cld6b16:~$

Verify VOLUME Proproties on both array

Volume on Primary Array
CSIM-EOS07_1611168 cli% showvv -cpg TEST_RC_SRC_CPG
                                                                                                             -Rsvd(MiB)- -(MiB)-
   Id Name Prov Compr Dedup Type CopyOf BsId Rd -Detailed_State- Snp Usr VSize
71596 osv-flL11RpzT4iiEjHtDC3SeQ cpvv NA NA base --- 71596 RW normal 1024 12288 12288
71597 rcpy.366.71596.11 snp NA NA vcopy osv-flL11RpzT4iiEjHtDC3SeQ 71596 RO normal -- -- 12288
--------------------------------------------------------------------------------------------------------------------------------
    2 total 1024 12288 24576
CSIM-EOS07_1611168 cli%

Volume on Primary Array
CSIM-EOS12_1611702 cli% showvv -cpg TEST_RC_DEST_CPG
                                                                                      -Rsvd(MiB)- -(MiB)-
  Id Name Prov Compr Dedup Type CopyOf BsId Rd -Detailed_State- Snp Usr VSize
8465 osv-flL11RpzT4iiEjHtDC3SeQ cpvv NA NA base --- 8465 RW normal 1024 12288 12288
---------------------------------------------------------------------------------------------------------
   1 total 1024 12288 12288
CSIM-EOS12_1611702 cli%

Volume on Primary Array

Volume on Secondary Array

WE could see both volume with full provisioning in above case.
Now we'll retype the volume and verify whether provisioning changes to thin or not

stack@cld6b16:~$ cinder retype 6628-Scenario-3 3pariscsirep
stack@cld6b16:~$ cinder list
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
| ID | Status | Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
| 7e52f5d5-1a73-4f88-a212-31ed0c2dd279 | available | 6628-Scenario-3 | 12 | 3pariscsirep1 | false | |
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
stack@cld6b16:~$ cinder list
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
| ID | Status | Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
| 7e52f5d5-1a73-4f88-a212-31ed0c2dd279 | available | 6628-Scenario-3 | 12 | 3pariscsirep1 | false | |
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+

Retype with migration policy parameter

stack@cld6b16:~$ cinder retype --migration-policy on-demand 6628-Scenario-3 3pariscsirep
cinder stack@cld6b16:~$ cinder list
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
| ID | Status | Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+
| 7e52f5d5-1a73-4f88-a212-31ed0c2dd279 | available | 6628-Scenario-3 | 12 | 3pariscsirep1 | false | |
+--------------------------------------+-----------+-----------------+------+---------------+----------+-------------+

RETYPE FAILED

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/500348

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/500348
Reason: No updates for a very long time. Feel free to restore and update if you wish to continue working on this.