Cinder

allocated_capacity_gb not reported on drivers that don't report pools

Bug #1712549 reported by Gorka Eguileor on 2017-08-23

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Cinder	Fix Released	Undecided	Gorka Eguileor

Bug Description

The allocated_capacity_gb is being calculated by the core Cinder code and then added to the driver provided stats, but it only works if the driver is reporting data of pools and it doesn't work if they are reporting the stats as the whole backend.

When reporting stats as the whole backend, which is the case of the RBD driver, we will not send allocated_capacity_gb to the manager.

Tags:

Gorka Eguileor (gorka) on 2017-08-23

Changed in cinder:
assignee:	nobody → Gorka Eguileor (gorka)
tags:	added: ceph drivers rbd

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-23: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/496685

Changed in cinder:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-05: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/496685
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1cae9a381dcffcfac13f19b723f02a84aabef595
Submitter: Jenkins
Branch: master

commit 1cae9a381dcffcfac13f19b723f02a84aabef595
Author: Gorka Eguileor <email address hidden>
Date: Wed Aug 23 14:08:59 2017 +0200

Fix allocated capacity report on non pool drivers

    The allocated_capacity_gb is being calculated by the core Cinder code and then
    added to the driver provided stats, but it only works if the driver is
    reporting data of pools and it doesn't work if they are reporting the
    stats as the whole backend.

When reporting stats as the whole backend, which is the case of the RBD
driver, we will not send allocated_capacity_gb to the manager.

    This patch fixes this by adding the stats from the special fixed pool
    that is created by the _count_allocated_capacity method for drivers that
    don't report pools information on stats from drivers that don't report
    pools information.

    Closes-Bug: #1712549
    Closes-Bug: #1706057
    Change-Id: Ia7ff6f05df85b1752b4e0353a734f3071dc8ff39

Changed in cinder:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-06: Fix proposed to cinder (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/501282

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-10: Fix merged to cinder (stable/pike)

Reviewed: https://review.openstack.org/501282
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=47836e02eff59a0a5188e68701214aff66dd25ad
Submitter: Jenkins
Branch: stable/pike

commit 47836e02eff59a0a5188e68701214aff66dd25ad
Author: Gorka Eguileor <email address hidden>
Date: Wed Aug 23 14:08:59 2017 +0200

Fix allocated capacity report on non pool drivers

    The allocated_capacity_gb is being calculated by the core Cinder code and then
    added to the driver provided stats, but it only works if the driver is
    reporting data of pools and it doesn't work if they are reporting the
    stats as the whole backend.

When reporting stats as the whole backend, which is the case of the RBD
driver, we will not send allocated_capacity_gb to the manager.

    Closes-Bug: #1712549
    Closes-Bug: #1706057
    Change-Id: Ia7ff6f05df85b1752b4e0353a734f3071dc8ff39
    (cherry picked from commit 1cae9a381dcffcfac13f19b723f02a84aabef595)
    Conflicts:
     cinder/tests/unit/volume/test_volume.py