GroupsTest.test_group_update failed with MismatchError: 2 != 1

[Ihar Hrachyshka]

Failed in Ocata: http://logs.openstack.org/53/494553/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/1793ab8/console.html

2017-08-17 16:11:10.518109 | tempest.api.volume.admin.test_groups.GroupsTest.test_group_update[id-4a8a6fd2-8b3b-4641-8f54-6a6f99320006]
2017-08-17 16:11:10.518164 | ----------------------------------------------------------------------------------------------------------
2017-08-17 16:11:10.518177 |
2017-08-17 16:11:10.518194 | Captured traceback:
2017-08-17 16:11:10.518209 | ~~~~~~~~~~~~~~~~~~~
2017-08-17 16:11:10.518237 | Traceback (most recent call last):
2017-08-17 16:11:10.518271 | File "tempest/api/volume/admin/test_groups.py", line 322, in test_group_update
2017-08-17 16:11:10.518292 | self.assertEqual(2, len(grp_vols))
2017-08-17 16:11:10.518334 | File "/opt/stack/new/tempest/.tox/tempest/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
2017-08-17 16:11:10.518357 | self.assertThat(observed, matcher, message)
2017-08-17 16:11:10.518397 | File "/opt/stack/new/tempest/.tox/tempest/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
2017-08-17 16:11:10.518416 | raise mismatch_error
2017-08-17 16:11:10.518437 | testtools.matchers._impl.MismatchError: 2 != 1

I am not an expert in Cinder, so it's hard to give more information.

[Lee Yarwood (lyarwood)]

Also seeing this in the stable/newton gate for Nova : http://logs.openstack.org/59/488959/1/gate/gate-tempest-dsvm-nnet-ubuntu-xenial/d91d375/console.html#_2017-08-21_05_28_49_782349

[Xing Yang (xing-yang)]

I think I know what the problem is now: The group status is updated before the
group_id is set/unset in the volumes during update_group.

We need to backport the following fix to stable/ocata and stable/newton.

https://review.openstack.org/#/c/484246/

I originally wrote the update_group tempest test in a way that this should not be a problem, but then after the above code change in Cinder, I modified the tempest test. So now the above fix needs to be backported to the older branches to work with this test. Otherwise we'll have to modify the tempest test to accommodate this problem.

[Xing Yang (xing-yang)]

Submitted a backport to stable/ocata:

https://review.openstack.org/#/c/501377/

Not sure what to do with stable/newton as it doesn't look like we can backport to there any more.

[Xing Yang (xing-yang)]

Backport to stable/ocata was merged: https://review.openstack.org/#/c/501377/

[Ihar Hrachyshka (ihar-hrachyshka)]

I think it's fine to skip newton.