update group status after update group_id in volumes

Bug #1704810 reported by Xing Yang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Xing Yang

Bug Description

In the volume manager, the group status is updated before the group_id is set/unset in the volumes during update_group. This is wrong because there's a slight change that the group could be modified after it becomes 'available' but before group_id is updated in all the volumes.

We should fix it by updating the group status after the group_id in all volumes are updated.

Revision history for this message
Xing Yang (xing-yang) wrote :
Changed in cinder:
assignee: nobody → Xing Yang (xing-yang)
importance: Undecided → Low
status: New → In Progress
tags: added: groups
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/484246
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=845cbd7dc0d88556c8a5398e4dfa49c46f0fba26
Submitter: Jenkins
Branch: master

commit 845cbd7dc0d88556c8a5398e4dfa49c46f0fba26
Author: xing-yang <email address hidden>
Date: Sun Jul 16 21:21:32 2017 -0700

    Update group status

    In the volume manager, the group status is updated before the
    group_id is set/unset in the volumes during update_group.
    This is wrong because there's a slight chance that the group
    could be modified after it becomes 'available' but before
    group_id is updated in all the volumes.

    This patch fixes it by updating the group status after the
    group_id in all volumes are updated.

    Closes-Bug: #1704810
    Change-Id: I451db1c8c49c4319323e5e0328c89c115d6047d1

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 11.0.0.0b3

This issue was fixed in the openstack/cinder 11.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/501377

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/ocata)

Reviewed: https://review.openstack.org/501377
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=107cac34a5ccc80cc84c3ae91b1879bdb872a48c
Submitter: Jenkins
Branch: stable/ocata

commit 107cac34a5ccc80cc84c3ae91b1879bdb872a48c
Author: xing-yang <email address hidden>
Date: Sun Jul 16 21:21:32 2017 -0700

    Update group status

    In the volume manager, the group status is updated before the
    group_id is set/unset in the volumes during update_group.
    This is wrong because there's a slight chance that the group
    could be modified after it becomes 'available' but before
    group_id is updated in all the volumes.

    This patch fixes it by updating the group status after the
    group_id in all volumes are updated.

    Closes-Bug: #1704810
    Change-Id: I451db1c8c49c4319323e5e0328c89c115d6047d1
    (cherry picked from commit 845cbd7dc0d88556c8a5398e4dfa49c46f0fba26)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.7

This issue was fixed in the openstack/cinder 10.0.7 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.