Cinder

lvm_type='auto' initializes vg incorrectly

Bug #1701547 reported by Eric Harney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Eric Harney

Bug Description

In the lvm driver, starting with lvm_type='auto' passes lvm_type='auto' to the lvm.LVM() init call.

The LVM() code assumes the input will be 'default' or 'thin'.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/479295

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/479295
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7033774fbb2f488fb0cfc94cf1a1d059b08b6d98
Submitter: Jenkins
Branch: master

commit 7033774fbb2f488fb0cfc94cf1a1d059b08b6d98
Author: Eric Harney <email address hidden>
Date: Fri Jun 30 08:14:04 2017 -0400

    LVM: Don't initialize VG with lvm_type='auto'

    The 'auto' arg should be translated to 'thin'
    for the lvm.LVM() call.

    Otherwise the checks for lvm_type=='thin' in the LVM()
    code do not function as intended.

    Closes-Bug: #1701547

    Change-Id: Ifad854e6f0ef23085ff7af608e290e62c2ad2554

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/483447

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/ocata)

Reviewed: https://review.openstack.org/483447
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1c2bfa9e4f57b75a85dd7ff0db426cf50c0d5583
Submitter: Jenkins
Branch: stable/ocata

commit 1c2bfa9e4f57b75a85dd7ff0db426cf50c0d5583
Author: Eric Harney <email address hidden>
Date: Fri Jun 30 08:14:04 2017 -0400

    LVM: Don't initialize VG with lvm_type='auto'

    The 'auto' arg should be translated to 'thin'
    for the lvm.LVM() call.

    Otherwise the checks for lvm_type=='thin' in the LVM()
    code do not function as intended.

    Closes-Bug: #1701547

    Change-Id: Ifad854e6f0ef23085ff7af608e290e62c2ad2554
    (cherry picked from commit 7033774fbb2f488fb0cfc94cf1a1d059b08b6d98)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.4

This issue was fixed in the openstack/cinder 10.0.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 11.0.0.0b3

This issue was fixed in the openstack/cinder 11.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.