Some drivers do not support extend volume if snapshots of this volume are present

Bug #1687048 reported by Silvan Kaiser on 2017-04-28
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Undecided
Silvan Kaiser
tempest
Undecided
Silvan Kaiser

Bug Description

A new tempest test was added with change https://review.openstack.org/#/c/200108/ that tests extending a volume that has snapshots in existence.
Several drivers currently do not support this: smbfs, Quobyte and VZstorage, the corresponding CIs fail on this test now.
These drivers are all remoteFS based and explicitly test and fail on this scenario (extend volume with snapshots).

I'm not sure why this limitation was explicitly added in earlier remotefs based drivers but in the GlusterFS driver this was removed in https://review.openstack.org/#/c/197645/1 .

I think the tempest test should be skipped until this bug is resolved.

This bug can probably be resolved by simply removing the check as was done with the GlusterFS driver but this should be tested first and checked.

Silvan Kaiser (2-silvan) wrote :

Quite possible some of the drivers may hit #1687044 after this issue has been solved. This issue is an explicit check that intentionally fails on the given scenario.

I had a quick chat with eharney who did the change on the gluster driver and I think I'll repeat that change on the hurting drivers.

Changed in cinder:
assignee: nobody → Silvan Kaiser (2-silvan)

Fix proposed to branch: master
Review: https://review.openstack.org/461466

Changed in tempest:
assignee: nobody → Silvan Kaiser (2-silvan)
status: New → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/461471

Changed in cinder:
status: New → In Progress

Change abandoned by Silvan Kaiser (<email address hidden>) on branch: master
Review: https://review.openstack.org/461466
Reason: Not skipping a test because of some drivers having issues.

@Jordan: Yep, i have seen skipping on the CIs here and there, i was just trying to improve on earlier behaviours :D

Silvan Kaiser (2-silvan) wrote :

Regarding tempest status going invalid: No skipping of a test because some drivers fail on it.

Changed in tempest:
status: In Progress → Invalid
Lucian Petrut (petrutlucian94) wrote :

This is a known limitation of the SMB driver as we're using differencing vhd/x images for snapshots.

While vhd images cannot be extended, I think we may allow this operation for vhdx images.

Silvan Kaiser (2-silvan) wrote :

@Lucian:
Please check out the submitted change at https://review.openstack.org/#/c/461471/ and see how that needs to be adopted for the SMB driver. If you want to submit a different patch for the SMB driver just drop me a note and I'll remove the SMB related changes from the patch.

Fix proposed to branch: master
Review: https://review.openstack.org/462905

Silvan Kaiser (2-silvan) wrote :

@Lucian: Pls check https://review.openstack.org/#/c/462902/ , now a separate change for the SMBfs fix.

Lucian Petrut (petrutlucian94) wrote :

@Silvan: thanks for sending this. It just needs a few small changes: checking the image format and resizing the latest image from the chain (as it is now, it's resizing the base image, corrupting the chain).

I'm updating the patch right away.

Lucian Petrut (petrutlucian94) wrote :

Hmm, just took a quick look at the nfs driver. I think it has the same issue: it's resizing the base image instead of the latest qcow2 image (when having snapshots).

https://github.com/openstack/cinder/blob/dbc9c7ca5903367b3782c303ff3574cd0e903e9f/cinder/volume/drivers/nfs.py#L356-L371

This looks like a bug to me.

Changed in cinder:
assignee: Silvan Kaiser (2-silvan) → Lucian Petrut (petrutlucian94)
Changed in cinder:
assignee: Lucian Petrut (petrutlucian94) → Silvan Kaiser (2-silvan)
Changed in cinder:
assignee: Silvan Kaiser (2-silvan) → Lucian Petrut (petrutlucian94)

Reviewed: https://review.openstack.org/461471
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=15eb00fc1e003868cd94dc9d83b155aaa5e34168
Submitter: Jenkins
Branch: master

commit 15eb00fc1e003868cd94dc9d83b155aaa5e34168
Author: Silvan Kaiser <email address hidden>
Date: Mon May 1 20:10:27 2017 +0200

    Allow extension of volumes with snapshots for Quobyte driver

    This change lifts an earlier limitation that explicitely did
    not extend a volume if snapshots of that volume exist. This
    limitation was lifted on the glusterfs driver and this change
    mirrors that behaviour but adds using the currently active
    image instead of the base file in case snapshots exist.

    Partial-bug: #1687048

    Change-Id: I75d25f6829d41ee2569ca3eaff63627f7c3876e0

Reviewed: https://review.openstack.org/462902
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c7fdc4d459a0bd09869bcc31f45499aa3274c760
Submitter: Jenkins
Branch: master

commit c7fdc4d459a0bd09869bcc31f45499aa3274c760
Author: Silvan Kaiser <email address hidden>
Date: Fri May 5 12:03:43 2017 +0200

    Allow extension of volumes with snapshots for SMBfs driver

    This change lifts an earlier limitation that explicitely did
    not extend a volume if snapshots of that volume exist.

    Note that we're still rejecting resize requests for volumes backed
    by VHD images when snapshots exist as the image format does not
    support it (this feature being available only for VHDX images).

    This change also ensures that we're resizing the latest image from
    the image chain.

    Co-Authored-By: Lucian Petrut <email address hidden>

    Partial-bug: #1687048

    Change-Id: Ib4546820f405e2986c1f3456b3b393fb6974e854

Unassigning due to no activity for > 6 months.

Changed in cinder:
assignee: Lucian Petrut (petrutlucian94) → nobody
status: In Progress → Triaged
Changed in cinder:
assignee: nobody → Silvan Kaiser (2-silvan)
status: Triaged → In Progress

Reviewed: https://review.openstack.org/462905
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7e5916ecdd89a0783ece2675704f701fbe845550
Submitter: Zuul
Branch: master

commit 7e5916ecdd89a0783ece2675704f701fbe845550
Author: Silvan Kaiser <email address hidden>
Date: Fri May 5 12:25:04 2017 +0200

    Allow extension of volumes with snapshots for VZstorage driver

    This change lifts an earlier limitation that explicitely did
    not extend a volume if snapshots of that volume exist. This
    limitation was lifted on the glusterfs driver and this change
    mirrors that behaviour.

    Partial-bug: #1687048

    Change-Id: I9aa727b1880b374105c2cad685dc196c7d39f841

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers